Closed
Bug 1337449
Opened 8 years ago
Closed 8 years ago
Simplify the code by removing the } else { after a break/return/continue
Categories
(NSPR :: NSPR, defect)
NSPR
NSPR
Tracking
(Not tracked)
RESOLVED
FIXED
4.16
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
28.38 KB,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
Fixed by clang-tidy - http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8834509 -
Flags: review?(kaie)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8834509 -
Flags: review?(kaie) → review?(ted)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8834509 [details] [diff] [review]
foo.diff
I have resigned as NSPR module owner. Sorry for the inconvenience.
Attachment #8834509 -
Flags: review?(ted)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8834509 [details] [diff] [review]
foo.diff
np, trying kaie
(I will probably have to rebase the patch)
Attachment #8834509 -
Flags: review?(kaie)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8834509 [details] [diff] [review]
foo.diff
Patch still applies cleanly.
r=kaie
I will check it in in a couple of days, we're currently frozen for the NSPR 4.15 release.
Attachment #8834509 -
Flags: review?(kaie) → review+
|
|
||
Updated•8 years ago
|
Flags: needinfo?(kaie)
Keywords: checkin-needed
|
|
||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/projects/nspr/rev/85977b5eba80
Let's set the target milestone to NSPR version 4.16, once bug 1370873 is done.
Status: NEW → RESOLVED
Closed: 8 years ago
Depends on: 1370873
Flags: needinfo?(kaie)
Keywords: checkin-needed
Resolution: --- → FIXED
|
|
||
Updated•8 years ago
|
Target Milestone: --- → 4.16
You need to log in
before you can comment on or make changes to this bug.
Description
•