Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove createCommandButtons / toolbarSpec

VERIFIED FIXED in Firefox 54

Status

()

Firefox
Developer Tools: Graphic Commandline and Toolbar
VERIFIED FIXED
6 months ago
3 months ago

People

(Reporter: jryans, Assigned: ochameau)

Tracking

Trunk
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
Bug 1320149 reworked the command buttons so that they don't use createCommandButtons / toolbarSpec anymore, but the code is still in place.
(Reporter)

Comment 1

6 months ago
:ochameau, should we remove this as well?
Flags: needinfo?(poirot.alex)
(Assignee)

Comment 2

6 months ago
Yes. I didn't realized createCommandButtons was only used there.
There may be even more to be removed?
Assignee: nobody → poirot.alex
Flags: needinfo?(poirot.alex)
Comment hidden (mozreview-request)
(Reporter)

Comment 4

6 months ago
mozreview-review
Comment on attachment 8834648 [details]
Bug 1337510 - Remove dead code related to gcli command buttons.

https://reviewboard.mozilla.org/r/110472/#review111786

Thanks, looks good to me!
Attachment #8834648 - Flags: review?(jryans) → review+

Comment 5

6 months ago
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01626a468701
Remove dead code related to gcli command buttons. r=jryans

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/01626a468701
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Comment 7

3 months ago
I have reproduced this bug on Firefox nightly according to (2017-02-07)

Fixing bug is verified on Latest Developer Edition--- Build ID: (20170427004028),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:54.0) Gecko/20100101 Firefox/54.0

Tested OS-- Windows7 32bit
[testday-20170428]
(Reporter)

Updated

3 months ago
Status: RESOLVED → VERIFIED
status-firefox54: fixed → verified
You need to log in before you can comment on or make changes to this bug.