1337510 - Remove createCommandButtons / toolbarSpec

Status: VERIFIED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug 1320149 reworked the command buttons so that they don't use createCommandButtons / toolbarSpec anymore, but the code is still in place.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:ochameau, should we remove this as well?

Comment 2

[Alexandre Poirot [:ochameau]]

Yes. I didn't realized createCommandButtons was only used there.
There may be even more to be removed?

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1337510 - Remove dead code related to gcli command buttons.

Review commit: https://reviewboard.mozilla.org/r/110472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110472/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8834648 [details]
Bug 1337510 - Remove dead code related to gcli command buttons.

https://reviewboard.mozilla.org/r/110472/#review111786

Thanks, looks good to me!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01626a468701
Remove dead code related to gcli command buttons. r=jryans

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/01626a468701

Comment 7

[Saheda Reza [:Antora]]

I have reproduced this bug on Firefox nightly according to (2017-02-07)

Fixing bug is verified on Latest Developer Edition--- Build ID: (20170427004028),User Agent: Mozilla/5.0 (Windows NT 6.1; rv:54.0) Gecko/20100101 Firefox/54.0

Tested OS-- Windows7 32bit
[testday-20170428]