1337572 - Improvements to linearize-git-to-hg to support Servo

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

I have a few improvements to linearize-git-to-hg that need landed in order to support Servo.

Comment 1

[Gregory Szorc [:gps]]

Attachment: vcssync: allow GitHub credentials to be defined in environment variables (bug 1337572);

So processes won't leak them in command line arguments, which can be
seen from pretty much every user on a system.

Review commit: https://reviewboard.mozilla.org/r/110524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110524/

Comment 2

[Gregory Szorc [:gps]]

Attachment: vcssync: support pushing converted Mercurial repo (bug 1337572);

As part of running a production service, we want to push the converted
Mercurial repo to another server as a means of backup. We already
support pushing the Git repo. So add functionality for pushing the
Mercurial repo.

Review commit: https://reviewboard.mozilla.org/r/110526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110526/

Comment 3

[Gregory Szorc [:gps]]

Attachment: vcssync: module to handle subscribing to Pulse events (bug 1337572);

Multiple VCS syncing services will want to react to Pulse events.
We create a generic mechanism for subscribing to the GitHub and
hg.mozilla.org Pulse exchanges.

Review commit: https://reviewboard.mozilla.org/r/110528/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110528/

Comment 4

[Gregory Szorc [:gps]]

Attachment: vcssync: daemon to trigger Servo events in response to Pulse (bug 1337572);

This commit introduces a daemon that listens for GitHub and hg.mo
Pulse events and triggers Servo-related VCS syncing actions. Well,
that's the theory. Currently, it doesn't actually trigger anything.
For that, we need Ansible infrastructure in place to define what
is triggered. That will be implemented in a later commit.

Review commit: https://reviewboard.mozilla.org/r/110544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110544/

Comment 5

[:glob ✱]

Comment on attachment 8834679 [details]
vcssync: allow GitHub credentials to be defined in environment variables (bug 1337572);

https://reviewboard.mozilla.org/r/110524/#review111878

Comment 6

[:glob ✱]

Comment on attachment 8834680 [details]
vcssync: support pushing converted Mercurial repo (bug 1337572);

https://reviewboard.mozilla.org/r/110526/#review111880

Comment 7

[:glob ✱]

Comment on attachment 8834685 [details]
vcssync: module to handle subscribing to Pulse events (bug 1337572);

https://reviewboard.mozilla.org/r/110528/#review111882

::: vcssync/setup.py:23
(Diff revision 1)
> -    install_requires=['dulwich>=0.16', 'github3.py>=0.9.6', 'Mercurial>=4.0'],
> +    install_requires=[
> +        'dulwich>=0.16',
> +        'github3.py>=0.9.6',
> +        'kombu>=3.0.37',
> +        'Mercurial>=4.0',
> +    ],

any reason why you didn't use https://hg.mozilla.org/automation/mozillapulse/ ?

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8834685 [details]
vcssync: module to handle subscribing to Pulse events (bug 1337572);

https://reviewboard.mozilla.org/r/110528/#review111882

> any reason why you didn't use https://hg.mozilla.org/automation/mozillapulse/ ?

It is universally agreed that the mozillapulse Python package is not great. Even mcote has advised me to just rewrite the 10-20 lines of Python needed to do consuming IIRC.

Comment 9

[:glob ✱]

Comment on attachment 8834685 [details]
vcssync: module to handle subscribing to Pulse events (bug 1337572);

https://reviewboard.mozilla.org/r/110528/#review112362

Comment 10

[:glob ✱]

Comment on attachment 8834709 [details]
vcssync: daemon to trigger Servo events in response to Pulse (bug 1337572);

https://reviewboard.mozilla.org/r/110544/#review112364

r=glob

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1245d69e8227
vcssync: allow GitHub credentials to be defined in environment variables ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/de567ce295ff
vcssync: support pushing converted Mercurial repo ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/976835adf843
vcssync: module to handle subscribing to Pulse events ; r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/9bbd05bcbad8
vcssync: daemon to trigger Servo events in response to Pulse ; r=glob