1337577 - Fix some runnable labeling issues with console runnables in tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Right now the console runnable is labeled with SystemGroup, so it's not allowed to run any content JS code. However, in a few tests, we use SpecialPowers to call into content JS from a console observer. Since console monitoring is async anyway, we can instead call the JS in a separate runnable. This avoids triggering labeling assertions in bug 1337537.

There are also a few runnables that do their own console monitoring without using SpecialPowers directly. I've fixed them to use SpecialPowers.

Comment 1

[Andrew McCreight [:mccr8]]

Comment on attachment 8834686 [details] [diff] [review]
patch

Review of attachment 8834686 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not too familiar with this, but it looks reasonable.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef98d3fdb36f
Ensure that console listeners never touch web content, including in tests (r=mccr8)

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef98d3fdb36f