Closed Bug 1337642 Opened 7 years ago Closed 7 years ago

fallbackMapping sidesteps checks on version and buildID increasing

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P1)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nthomas, Assigned: ninad101)

References

(
URL
)

Details

(Whiteboard: [lang=python][ready]) 

(This is from code inspection so ymmv).

Bug 1282891 added the fallbackMapping for the case where we are throttled and lose the dice roll. Unfortunately it avoids the blob.shouldServeUpdate() check which ensures we don't offer a version downgrade, or if the version is the same a buildID downgrade.

I think we just need the check at line 101-102 inserted between lines 90 and 91.
Assignee: nobody → bhat.ninadmb
I will look at this today.
Yikes, this is pretty serious. Thanks for picking it up Ninad. I see you've created a PR already. I'll have a look at it shortly, and hopefully we can get it into today's production push.
Priority: -- → P1
Whiteboard: [lang=python][ready]
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/4c49780e51511faf1220324d4c19e6fb4ce5fe71
Bug 1337642 - fallbackMapping sidesteps checks on version and buildID increasing  (#243). r=bhearsum
I'm super impressed with how fast this was fixed. Thank you a ton Ninad!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Thanks Ninad!
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.