Closed Bug 1337682 Opened 7 years ago Closed 7 years ago

using ctrl / shift + enter seems to save the URL to a hidden clipboard that populates when hitting enter (hard to describe).

Categories

(Firefox :: Address Bar, defect, P1)

51 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox51 --- wontfix
firefox52 --- wontfix
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: u588658, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

1. Open a new tab, type in anywebsite and press ctrl + enter (or shift + enter, or shift + ctrl + enter). It will take you to www.anywebsite.com. Expected behavior.

2. Now, switch to another tab, or open a new tab. Select the address bar and press enter. It will take you to www.anywebsite.com, even if you have the current page's address URL selected (which should refresh the page) or do nothing (if blank).
Component: Untriaged → Location Bar
OS: Unspecified → All
Hardware: Unspecified → All
do you have any add-ons that touch the awesomebar?
Could you please try in Safe mode that will temporarily disable your add-ons?
https://support.mozilla.org/t5/Procedures-to-diagnose-and-fix/Troubleshoot-Firefox-issues-using-Safe-Mode/ta-p/1687

I have some suspect, we indeed temporarily store the previous typed value for CTRL+ENTER but we should be clearing it. In some cases (bug 1323682) it's not cleared. At this point we should ensure a better clearing strategy.
I'm taking this to investigate strategies.
Assignee: nobody → mak77
Status: UNCONFIRMED → ASSIGNED
Depends on: 1323682
Ever confirmed: true
Priority: -- → P1
Whiteboard: [fxsearch]
Blocks: 1334844
Blocks: 1323682
No longer depends on: 1323682
gentle review ping, we should uplift this as far as possible. I can move the review to Mark if you're having too much work atm, just let me know.
Flags: needinfo?(adw)
Blocks: 1333345
Comment on attachment 8837708 [details]
Bug 1337682 - CanonizeURL feature may override the next load of the current URL.

https://reviewboard.mozilla.org/r/112754/#review117798

Sorry Marco, this looks fine to me.
Attachment #8837708 - Flags: review?(adw) → review+
Flags: needinfo?(adw)
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/cc6aba2aa355
CanonizeURL feature may override the next load of the current URL. r=adw
https://hg.mozilla.org/mozilla-central/rev/cc6aba2aa355
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8837708 [details]
Bug 1337682 - CanonizeURL feature may override the next load of the current URL.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1306639
[User impact if declined]: If the user uses SHIFT+Enter or CTRL+Enter to complete words to domains in the locationbar, sometimes we could load the previously completed domain instead of the new typed one.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: it would be nice, STR are in comment 0
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial code change with unit test
[String changes made/needed]: none
Attachment #8837708 - Flags: approval-mozilla-esr52?
Attachment #8837708 - Flags: approval-mozilla-aurora?
Comment on attachment 8837708 [details]
Bug 1337682 - CanonizeURL feature may override the next load of the current URL.

OK for aurora 53, this missed the upcoming 52esr though.
Attachment #8837708 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8837708 [details]
Bug 1337682 - CanonizeURL feature may override the next load of the current URL.

fix an issue with CanonizeURL overriding things it shouldn't, esr52+
Attachment #8837708 - Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
You need to log in before you can comment on or make changes to this bug.