1337695 - stylo: layout/reftests/bugs/99850-1a.html fatally asserts with "aRestlyeHint == 0"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Cameron McCormack (:heycam)]

While testing the latest mozilla-central merge, it looks like bug 1330041 causes layout/reftests/bugs/99850-1a.html to fatally assert.  Manish, did you do a try run with |-p linux64-stylo -u reftest-stylo|?  (I don't know if mozreview keeps a history of all previous try runs and their results; the only one I can see on there is for a non-stylo build.)

Assertion failure: aRestyleHint == 0, at /z/stylo/hg-incubator/layout/base/ServoRestyleManager.cpp:53
#01: mozilla::ServoRestyleManager::PostRestyleEvent(mozilla::dom::Element*, nsRestyleHint, nsChangeHint) (/z/stylo/hg-incubator/layout/base/ServoRestyleManager.cpp:53 (discriminator 5))
#02: mozilla::RestyleManagerHandle::Ptr::PostRestyleEvent(mozilla::dom::Element*, nsRestyleHint, nsChangeHint) (/z/stylo/hg-incubator/obj/dist/include/mozilla/RestyleManagerHandleInlines.h:49)
#03: nsHTMLStyleSheet::ImplLinkColorSetter(RefPtr<nsHTMLStyleSheet::HTMLColorRule>&, unsigned int) (/z/stylo/hg-incubator/layout/style/nsHTMLStyleSheet.cpp:505)
#04: nsHTMLStyleSheet::SetLinkColor(unsigned int) (/z/stylo/hg-incubator/layout/style/nsHTMLStyleSheet.cpp:512)
#05: mozilla::dom::HTMLBodyElement::MapAttributesIntoRule(nsMappedAttributes const*, nsRuleData*) (/z/stylo/hg-incubator/dom/html/HTMLBodyElement.cpp:377)
#06: nsMappedAttributes::MapRuleInfoInto(nsRuleData*) (/z/stylo/hg-incubator/dom/base/nsMappedAttributes.cpp:191)
#07: nsMappedAttributes::LazilyResolveServoDeclaration(nsRuleData*, nsCSSPropertyID*, unsigned long) (/z/stylo/hg-incubator/dom/base/nsMappedAttributes.cpp:297 (discriminator 1))
#08: nsHTMLStyleSheet::CalculateMappedServoDeclarations() (/z/stylo/hg-incubator/layout/style/nsHTMLStyleSheet.cpp:642)
#09: mozilla::ServoStyleSet::ResolveMappedAttrDeclarationBlocks() (/z/stylo/hg-incubator/layout/style/ServoStyleSet.cpp:188)
#10: mozilla::ServoStyleSet::PrepareAndTraverseSubtree(mozilla::dom::Element const*, mozilla::TraversalRootBehavior) (/z/stylo/hg-incubator/layout/style/ServoStyleSet.cpp:194)
#11: mozilla::ServoStyleSet::StyleDocument() (/z/stylo/hg-incubator/layout/style/ServoStyleSet.cpp:560 (discriminator 2))
#12: mozilla::ServoRestyleManager::ProcessPendingRestyles() (/z/stylo/hg-incubator/layout/base/ServoRestyleManager.cpp:342)
#13: mozilla::RestyleManagerHandle::Ptr::ProcessPendingRestyles() (/z/stylo/hg-incubator/obj/dist/include/mozilla/RestyleManagerHandleInlines.h:76)
#14: mozilla::PresShell::FlushPendingNotifications(mozilla::ChangesToFlush) (/z/stylo/hg-incubator/layout/base/PresShell.cpp:4171 (discriminator 3))
#15: nsRefreshDriver::Tick(long, mozilla::TimeStamp) (/z/stylo/hg-incubator/layout/base/nsRefreshDriver.cpp:1837)

Comment 1

[Manish Goregaokar [:manishearth]]

I think I did but that might have been in an earlier version of the patch.

The active link stuff is going to be tricky, the best thing to do in this case is only call SetLinkColor in gecko mode.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

The assertion has been gone.  Three reftests (99850-1a, 99850-1b.html 99850-1d.html) sill fail but should be run.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9512004b236f18cbd8c0e8eff7d2113d0bc64b4

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1337695 - Enable tests which had been affected by an assertiton with "aRestlyeHint == 0".

The assertion has been gone, three reftests in this patch
still fail but should be run now.

Review commit: https://reviewboard.mozilla.org/r/125702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125702/

Comment 4

[Shing Lyu [:shinglyu]]

Comment on attachment 8853614 [details]
Bug 1337695 - Enable tests which had been affected by an assertiton with "aRestlyeHint == 0".

https://reviewboard.mozilla.org/r/125702/#review129314

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4305f22e882c
Enable tests which had been affected by an assertiton with "aRestlyeHint == 0". r=shinglyu

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4305f22e882c