If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Update to Celery/Kombu 4.x

NEW
Unassigned

Status

Tree Management
Treeherder
P3
normal
8 months ago
8 months ago

People

(Reporter: emorley, Unassigned)

Tracking

Details

(Reporter)

Description

8 months ago
Broken out of bug 1333079 since the original landing had to be reverted.

We're currently using Celery/Kombu 3.x and at some point should try again switching to the latest 4.x series.

One of the smaller but helpful for us fixes that this brings, is the change to py-amqp that displays more helpful error messages in case of incorrect rabbitmq password (which has bitten us many times in the past). Only Celery/Kombu 4.x are compatible with this newer py-amqp.

Since the original landing attempt in bug 1333079, some possible regressions in Celery 4.x were reported in the celery issue tracker:
https://github.com/celery/celery/issues/3814
https://github.com/celery/celery/issues/3737

Given that's I'm inclined to wait a bit longer for Celery 4.x to mature first.

When we do attempt this again, we'll need to reland:
https://github.com/mozilla/treeherder/commit/f09694e3ccb60393ea171e2923a0633186049124
https://github.com/mozilla/treeherder/commit/1db3e2baf46c5df426dc234657d94e9585668456

...and then fix the cause of everything being put in the "default" queue (bug 1333079 comment 9).
You need to log in before you can comment on or make changes to this bug.