Disable E129 pyflakes lint

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jgraham, Assigned: jgraham)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This is the one that forces you to write something weird like

if (something and
        something_else):
    pass

just because it doesn't like the fact that "if (" is four characters. I don't think that the problem it's trying to solve is actually confusing, the alternative doesn't work well with my editor, and I think the code you wind up with trying to pacify the linter is really ugly to read. So let's just disable this check.
Created attachment 8835551 [details] [review]
[treeherder] mozilla:disable_E129 > mozilla:master
(Assignee)

Updated

2 years ago
Attachment #8835551 - Flags: review?(emorley)
Attachment #8835551 - Flags: review?(emorley) → review+
Assignee: nobody → james

Comment 2

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/067aad46bd4c2f1c298326bddeaef8cc118dfe34
Bug 1337726 - Disable E129 pyflakes lint.

This demands a weird style when using
if (something and
    something_else):

which is not really helpful to code readability.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.