Closed Bug 1337729 Opened 3 years ago Closed 3 years ago

Reenable browser_privatebrowsing_concurrent.js for e10s

Categories

(Testing :: General, defect)

Version 3
defect
Not set

Tracking

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 fixed, firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
mozilla55
Iteration:
55.1 - Mar 20
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: gkrizsanits, Assigned: gkrizsanits)

References

(Blocks 1 open bug)

Details

(Whiteboard: [e10s-multi:?])

Attachments

(1 file)

No description provided.
Blocks: 1315042
Attached patch quickfixSplinter Review
This is just another early return from browser loaded: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d70a62e8e18a5561c4581352dc9f303684ca34a8

It's weird that only this call has this issue... I'm not sure it is worth to look into this more given that you're working on a quite similar issue for the middle click referrer tests.
Attachment #8841923 - Flags: review?(mrbkap)
Whiteboard: [e10s-multi:?]
Attachment #8841923 - Flags: review?(mrbkap) → review+
The problem here is that browserLoaded basically can't be combined easily with any other way of waiting for a load to finish. In particular, anything that waits for STATE_STOP will race messages between the parent and the child for the onStateChange and the actual load event. This approach of fixing the intermittent is probably the most efficient way to do it.
Pushed by gkrizsanits@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fcb7e13923d
Reenable browser_privatebrowsing_concurrent.js. r=mrbkap
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/081a720da263
Reenable browser_privatebrowsing_concurrent.js: use doublequotes to make eslint happy. r=eslint-fix
https://hg.mozilla.org/mozilla-central/rev/9fcb7e13923d
https://hg.mozilla.org/mozilla-central/rev/081a720da263
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Iteration: --- → 55.1 - Mar 20
Assignee: nobody → gkrizsanits
You need to log in before you can comment on or make changes to this bug.