1337785 - UA override web compat add-on generates a lot of uncaught exceptions from the DNS service

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, defect)

Description

[:Gijs (he/him)]

Unfortunately the effective tld service:

1) doesn't like you passing it no-dot hosts (say, "http://mochitest:8888/")
2) doesn't like you passing it IP addresses (say, "http://127.0.0.1:8888/")
3) is generally pretty picky.

The code at https://dxr.mozilla.org/mozilla-central/rev/f4f374622111022d41dd8d5eb9220624135c534a/browser/extensions/webcompat/content/lib/ua_overrider.jsm#109 should be catching those exceptions and return early / ignore those cases, rather than letting those exceptions propagate, spam the console etc.

Comment 1

[Dennis Schubert [:denschub]]

Thanks for the report. That is indeed an issue we have not thought about.

Comment 2

[Dennis Schubert [:denschub]]

Attachment: Pull request, Version 1

We generally don't plan on overriding local ressources and only target high-profile issues, which usually have a domain, so simply ignoring cases where we can't get the base domain seems like a good way forward.

Eric, could you have a look please?

Comment 3

[Dennis Schubert [:denschub]]

Merged into the GitHub repo, will be synced to m-c soon. Thanks again for the report.