1337830 - [DateTimeInput] Home/End keys change year values in the input box

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[roxleitan]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID:20170208030203

[Affected versions]:
Nightly 54.0a1

[Affected platforms]:
All platforms: Ubuntu 16.04, Mac OS X 10.11, Windows 10

[Steps to reproduce]:
1.Launch Nightly 54.0a1 with a new profile
2.Set "dom.forms.datetime" and "dom.forms.datetime.timepicker" pref to True in about:config
3.In the URL bar enter "data:text/html, <input type="date">"
4.Press tab key to move focus on year segment
5.Press Home/End keys

[Expected result]:
Home/End keys should do nothing on year segment.

[Actual result]:
Home key changes year value to "0001" and End key changes to "275760"

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: Bug 1337830 - [DateTimeInput] Home/End keys should have no effect on year field.

Review commit: https://reviewboard.mozilla.org/r/140890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140890/

Comment 2

[Jessica Jong [:jessica] (inactive)]

Hi mossop, could you take a look at this small change to meet the UX spec? Thanks.

Comment 3

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8869333 [details]
Bug 1337830 - [DateTimeInput] Home/End keys should have no effect on year field.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140890/diff/1-2/

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8869333 [details]
Bug 1337830 - [DateTimeInput] Home/End keys should have no effect on year field.

https://reviewboard.mozilla.org/r/140890/#review144672

Comment 5

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=695c1645e565ba6516a7f65e9671a6579b025bb4&group_state=expanded

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6be024548cd
[DateTimeInput] Home/End keys should have no effect on year field. r=mossop

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b6be024548cd

Comment 8

[Gerry Chang [:gchang]]

Mark 54 won't fix as this is late for Beta54.

Comment 9

[roxleitan]

Verified fixed on the latest Nightly 55.0a1 (2017-06-07) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.