Closed Bug 1337858 Opened 4 years ago Closed 4 years ago

Replace CopyFavicon in Docshell with a proper API

Categories

(Toolkit :: Places, defect, P1)

Product:
Toolkit
Component:
Places
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1337858 - Replace CopyFavicon in the Docshell with a proper favicons API.
59 bytes, text/x-review-board-request
standard8
: review+
Details 
The current one will only copy one payload, that is not what we want in general.
Priority: P3 → P1
while here could also fix back/forward menu to use page-icon instead of getFaviconUrlForPage
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Comment on attachment 8870735 [details]
Bug 1337858 - Replace CopyFavicon in the Docshell with a proper favicons API.

https://reviewboard.mozilla.org/r/142224/#review149212

Looks good, r=Standard8
Attachment #8870735 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/d48d0c5b0191
Replace CopyFavicon in the Docshell with a proper favicons API. r=standard8
https://hg.mozilla.org/mozilla-central/rev/d48d0c5b0191
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
54 RC build is released. Mark 54 won't fix.
status-firefox54: affected → wontfix
it's actually unaffected, this work is just needed for the new favicons store.
status-firefox54: wontfix → unaffected
Depends on: 1386576
You need to log in before you can comment on or make changes to this bug.