Replace CopyFavicon in Docshell with a proper API

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Places
P1
normal
RESOLVED FIXED
9 months ago
3 months ago

People

(Reporter: mak, Assigned: mak)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox54 unaffected, firefox55 fixed)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
The current one will only copy one payload, that is not what we want in general.
(Assignee)

Updated

7 months ago
Priority: P3 → P1
(Assignee)

Comment 1

6 months ago
while here could also fix back/forward menu to use page-icon instead of getFaviconUrlForPage
(Assignee)

Updated

5 months ago
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 3

5 months ago
mozreview-review
Comment on attachment 8870735 [details]
Bug 1337858 - Replace CopyFavicon in the Docshell with a proper favicons API.

https://reviewboard.mozilla.org/r/142224/#review149212

Looks good, r=Standard8
Attachment #8870735 - Flags: review?(standard8) → review+
Comment hidden (mozreview-request)

Comment 5

5 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/d48d0c5b0191
Replace CopyFavicon in the Docshell with a proper favicons API. r=standard8

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d48d0c5b0191
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
54 RC build is released. Mark 54 won't fix.
status-firefox54: affected → wontfix
(Assignee)

Comment 8

5 months ago
it's actually unaffected, this work is just needed for the new favicons store.
status-firefox54: wontfix → unaffected

Updated

3 months ago
Depends on: 1386576
You need to log in before you can comment on or make changes to this bug.