Closed Bug 1337919 Opened 8 years ago Closed 8 years ago

Search for "AppendInt" finds 64-bit overload definitions as textual occurrences

Categories

(Webtools :: Searchfox, defect)

Product:
Webtools
Component:
Searchfox
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kats, Assigned: billm)

Details

http://searchfox.org/mozilla-central/search?q=AppendInt There are a bunch of AppendInt functions defined in nsTSubstring.h - there are ones that take a 32-bit integer and ones that take a 64-bit integer. Searchfox lists the 32-bit ones at the top of the results under "definitions", but the 64-bit ones are near the bottom of the search results, in the "uses" section. They should be in the "definition" section also.
Oh whoops, it actually puts the 64-bit versions under "Textual Occurrences", not "Uses". That still seems wrong but that's less bad at least.
Summary: Search for "AppendInt" finds 64-bit overload definitions as uses → Search for "AppendInt" finds 64-bit overload definitions as textual occurrences
There had been a heuristic where the number of "identifier results" was limited to 5. I've now changed how the heuristic works. Hope it improves things. https://github.com/bill-mccloskey/searchfox/commit/f8f8f31129f8551fcdcb781cb6c0454789d95923
Assignee: nobody → wmccloskey
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Awesome, thanks!
You need to log in before you can comment on or make changes to this bug.