1337929 - make it possible to link to the Rules page with a specific filter

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P3)

Description

[[e-mail] (:bhearsum)]

When we used a free text filter, we were able to send links to the Rules page with a filter applied. Since we switched to the drop down, we haven't been able to do that anymore. We should remedy that! I think all we need to is reflect the value of the current drop down filter in the URL.

Comment 1

[Wasif Hyder]

The relevant information is already stored in local storage under the key 'pr_ch_filter'. Is there any way we can load pass that parameter to the URL?

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Wasif Hyder from comment #1)
> The relevant information is already stored in local storage under the key
> 'pr_ch_filter'. Is there any way we can load pass that parameter to the URL?

I think so. We do something similar on the Releases page when the free text filter is used. Have a look at the usages of "$location" in https://github.com/mozilla/balrog/blob/master/ui/app/js/controllers/releases_controller.js.

Comment 3

[akriti verma]

Hi Ben, I just want to know which dropdown menu you are referring to.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to akriti verma from comment #3)
> Hi Ben, I just want to know which dropdown menu you are referring to.

Once you have the development environment running, go to http://localhost:8080/rules -- there is a drop down labeled "Product/Channel filter".

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/0739d5bbe52cb20da9e3b06cbe88f36315c7bc27
bug 1337929: make it possible to link to the Rules page with a specific filter (#406). r=bhearsum

Comment 6

[[e-mail] (:bhearsum)]

This went into production today. Thank you for implementing it Alvin!