Closed Bug 1337938 Opened 3 years ago Closed 2 years ago

Add test to check all permissions (that need one) have a localization string

Categories

(WebExtensions :: General, defect, P3)

defect

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: zombie, Assigned: zombie)

References

Details

(Whiteboard: triaged)

Attachments

(1 file)

No description provided.
Priority: -- → P3
Whiteboard: triaged
A new api/permissions without a localization message just landed (see bug 1332144 comment #139), we should really prevent that from happening again.
Assignee: nobody → tomica
Status: NEW → ASSIGNED
Depends on: 1394134
Comment on attachment 8901488 [details]
Bug 1337938 - Add test for permissions localization strings

https://reviewboard.mozilla.org/r/172944/#review178320

::: toolkit/components/extensions/test/xpcshell/test_ext_permissions.js:373
(Diff revision 1)
> +  "activeTab", "alarms", "browsingData", "contextMenus", "contextualIdentities",
> +  "cookies", "downloads.open", "downloads.shelf", "geckoProfiler", "identity",
> +  "idle", "menus", "proxy", "storage", "theme", "webRequest", "webRequestBlocking",

Nit: Please make this one-permission-per-line. It will be much easier to maintain that way.
Attachment #8901488 - Flags: review+
Comment on attachment 8901488 [details]
Bug 1337938 - Add test for permissions localization strings

https://reviewboard.mozilla.org/r/172944/#review178422

Nice, thanks!
Attachment #8901488 - Flags: review?(aswan) → review+
Depends on: 1394553
I decided to land this as is, and prune the list / update the test after bug 1394134 and bug 1394553 are fixed.
Pushed by tomica@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b4adce8af178
Add test for permissions localization strings  r=aswan,kmag
https://hg.mozilla.org/mozilla-central/rev/b4adce8af178
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.