Closed Bug 1337951 Opened 3 years ago Closed 3 years ago

Add separator above menu items for sideloaded/updated addons

Categories

(Toolkit :: Add-ons Manager, defect, P3)

51 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla54
Tracking Status
firefox54 --- verified

People

(Reporter: aswan, Assigned: mstriemer)

References

Details

(Whiteboard: triaged)

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1334010 +++

From https://bugzilla.mozilla.org/show_bug.cgi?id=1334010#c20

I noticed that the current implementation of the notification misses the separator line on top that other notifications in that area have.
Attached image separators-added.png
Comment on attachment 8842214 [details]
Bug 1337951 - Add separator above sideloaded/updated add-ons in menu

https://reviewboard.mozilla.org/r/116114/#review117628
Attachment #8842214 - Flags: review?(aswan) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55f798bd9db4
Add separator above sideloaded/updated add-ons in menu r=aswan
(In reply to Mark Striemer [:mstriemer] from comment #3)
> Created attachment 8842226 [details]
> separators-added.png

it looks good.
https://hg.mozilla.org/mozilla-central/rev/55f798bd9db4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Verified fixed on Firefox 54.0a1 (2017-03-03) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1 . The separator is correctly displayed above menu items for sideloaded/updated addons: https://www.screencast.com/t/txiivg3UF
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.