[RTL] Fix paddings in the linear tabs layout for RTL

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
Theme and Visual Design
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: Tom Klein, Assigned: Tom Klein)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox53 fixed, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

4 months ago
Created attachment 8835243 [details]
linear tabs layout padding errors

Some of the paddings in the linear tabs layout aren't set for RTL: there's an outer padding on the thumbnail side that doesn't get reversed in RTL (shows up as too much padding on the left and too little padding on the right in the screenshot), and there are different paddings on the two sides of the title that don't get reversed in RTL (though it's hard to tell visually).
Comment hidden (mozreview-request)
(Assignee)

Comment 2

4 months ago
Created attachment 8835261 [details]
left side: LTR; right side: RTL, both with the patch

Screenshot of LTR and RTL with the patch.
Attachment #8835260 - Flags: review?(max)

Comment 3

4 months ago
mozreview-review
Comment on attachment 8835260 [details]
Bug 1338027 - Fix RTL padding in the linear tabs layout.

https://reviewboard.mozilla.org/r/110968/#review112314

LGTM! Added Max, who's been working on making Fennec support RTL, as second reviewer.
Attachment #8835260 - Flags: review?(s.kaspari) → review+

Comment 4

4 months ago
mozreview-review
Comment on attachment 8835260 [details]
Bug 1338027 - Fix RTL padding in the linear tabs layout.

https://reviewboard.mozilla.org/r/110968/#review112676

LGTM! Thanks, Tom. :)
Attachment #8835260 - Flags: review?(max) → review+

Comment 5

4 months ago
Pushed by twointofive@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/101c4902811d
Fix RTL padding in the linear tabs layout. r=maliu,sebastian

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/101c4902811d
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Comment 7

3 months ago
Seems to be fixed on latest Nightly, according to Tom's last screenshot.
(Assignee)

Comment 8

3 months ago
Max, RTL is landing in 53, right?  Should I request uplift to aurora for this and bug 1337897?
Flags: needinfo?(max)

Comment 9

3 months ago
Tom, sure do. Both patch have no risk on uplift, please request uplift to aurora. Thank you.
Flags: needinfo?(max)
(Assignee)

Comment 10

3 months ago
Comment on attachment 8835260 [details]
Bug 1338027 - Fix RTL padding in the linear tabs layout.

Approval Request Comment
[Feature/Bug causing the regression]: RTL for fennec
[User impact if declined]: in RTL mode some of the padding on the tabs tray in portrait mode will be wrong (see the first screenshot).
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No I guess. I'm never sure under what conditions I'm supposed to say yes to this :P 
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: The old padding values still exist and haven't changed, we're simply adding extra padding information in the way required by android for RTL.
[String changes made/needed]: None
Attachment #8835260 - Flags: approval-mozilla-aurora?

Updated

3 months ago
status-firefox53: --- → affected
Comment on attachment 8835260 [details]
Bug 1338027 - Fix RTL padding in the linear tabs layout.

Fix an RTL padding issue in the linear tabs. This polish the UI. Aurora53+.
Attachment #8835260 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 12

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/bdd89262f426
status-firefox53: affected → fixed
You need to log in before you can comment on or make changes to this bug.