1338027 - [RTL] Fix paddings in the linear tabs layout for RTL

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Tom Klein]

Attachment: linear tabs layout padding errors

Some of the paddings in the linear tabs layout aren't set for RTL: there's an outer padding on the thumbnail side that doesn't get reversed in RTL (shows up as too much padding on the left and too little padding on the right in the screenshot), and there are different paddings on the two sides of the title that don't get reversed in RTL (though it's hard to tell visually).

Comment 1

[Tom Klein]

Attachment: Bug 1338027 - Fix RTL padding in the linear tabs layout.

Review commit: https://reviewboard.mozilla.org/r/110968/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110968/

Comment 2

[Tom Klein]

Attachment: left side: LTR; right side: RTL, both with the patch

Screenshot of LTR and RTL with the patch.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8835260 [details]
Bug 1338027 - Fix RTL padding in the linear tabs layout.

https://reviewboard.mozilla.org/r/110968/#review112314

LGTM! Added Max, who's been working on making Fennec support RTL, as second reviewer.

Comment 4

[Max Liu [:maliu]]

Comment on attachment 8835260 [details]
Bug 1338027 - Fix RTL padding in the linear tabs layout.

https://reviewboard.mozilla.org/r/110968/#review112676

LGTM! Thanks, Tom. :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/101c4902811d
Fix RTL padding in the linear tabs layout. r=maliu,sebastian

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/101c4902811d

Comment 7

[Itiel]

Seems to be fixed on latest Nightly, according to Tom's last screenshot.

Comment 8

[Tom Klein]

Max, RTL is landing in 53, right?  Should I request uplift to aurora for this and bug 1337897?

Comment 9

[Max Liu [:maliu]]

Tom, sure do. Both patch have no risk on uplift, please request uplift to aurora. Thank you.

Comment 10

[Tom Klein]

Comment on attachment 8835260 [details]
Bug 1338027 - Fix RTL padding in the linear tabs layout.

Approval Request Comment
[Feature/Bug causing the regression]: RTL for fennec
[User impact if declined]: in RTL mode some of the padding on the tabs tray in portrait mode will be wrong (see the first screenshot).
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No I guess. I'm never sure under what conditions I'm supposed to say yes to this :P 
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: The old padding values still exist and haven't changed, we're simply adding extra padding information in the way required by android for RTL.
[String changes made/needed]: None

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8835260 [details]
Bug 1338027 - Fix RTL padding in the linear tabs layout.

Fix an RTL padding issue in the linear tabs. This polish the UI. Aurora53+.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bdd89262f426