Closed Bug 1338082 Opened 3 years ago Closed 3 years ago

Add telemetry probes to track the positive and negative cache durations in V4

Categories

(Toolkit :: Safe Browsing, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: francois, Assigned: dimi)

References

Details

(Whiteboard: #sbv4-m5)

Attachments

(1 file)

In order to pick a good fixed negative cache duration for V2 (as suggested on bug 1333328), we should keep track of the cache duration values we receive from Google.

This is an exploratory probe, it doesn't need to be permanent.
We should also add a probe to keep track of the positive cache duration values we get.
Summary: Add a telemetry probe to track the negative cache duration we get out of Google's V4 server → Add telemetry probes to track the positive and negative cache durations in V4
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8836968 [details]
Bug 1338082 - Add telemetry probes to track the positive and negative cache durations in V4.

https://reviewboard.mozilla.org/r/112270/#review115188

With the small changes below, r+ and datareview+.

::: toolkit/components/telemetry/Histograms.json:4132
(Diff revision 1)
>    },
> +  "URLCLASSIFIER_POSITIVE_CACHE_DURATION": {
> +    "alert_emails": ["safebrowsing-telemetry@mozilla.org"],
> +    "expires_in_version": "60",
> +    "kind": "exponential",
> +    "high": 3600000,

`3600000` ms is one hour. Let's make the maximum value larger in case Google does send us weirdly large values.

I would suggest 24 hours.

::: toolkit/components/telemetry/Histograms.json:4135
(Diff revision 1)
> +    "expires_in_version": "60",
> +    "kind": "exponential",
> +    "high": 3600000,
> +    "n_buckets": 50,
> +    "bug_numbers": [1338082],
> +    "description": "Positive cache duration (ms) received in fullhash response"

I would add the following to the end of the description to make it more precise:

    from any V4 provider
Attachment #8836968 - Flags: review?(francois) → review+
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/585ddf7e746f
Add telemetry probes to track the positive and negative cache durations in V4. r=francois
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/585ddf7e746f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.