Closed Bug 1338144 Opened 3 years ago Closed 3 years ago

disable service workers and push notifications on 52 ESR

Categories

(Core :: DOM: Service Workers, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox52 --- wontfix
firefox-esr52 52+ verified
firefox53 --- wontfix
firefox54 --- wontfix

People

(Reporter: bkelly, Assigned: baku)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file, 1 obsolete file)

As discussed on dev-platform we would like to disable service workers in FF 52 ESR.  We expect to make large changes to SW and it would be difficult to maintain uplifts across this architectural change.

We would also need to disable push notifications since they require service workers.
Mark P1 as we need it now.
Priority: -- → P1
Andrew, can you find someone to do this?  Probably have to fight with tests a bit.
Flags: needinfo?(overholt)
baku, can you help out here? It's pretty time-sensitive.
Flags: needinfo?(overholt) → needinfo?(amarchesini)
it seems to me that SWs are disabled in ESR-52:
https://hg.mozilla.org/releases/mozilla-esr52/file/tip/modules/libpref/init/all.js#l155
Flags: needinfo?(amarchesini)
Flags: needinfo?(bkelly)
Maybe the prefs were imported from 45esr?  Do we need any prefs set for notifications?
Flags: needinfo?(bkelly)
(In reply to Ben Kelly [:bkelly] from comment #6)
> Maybe the prefs were imported from 45esr?  Do we need any prefs set for
> notifications?

We don't want to turn off web notifications entirely, right? Just notifications triggered from push messages?
Flags: needinfo?(bkelly)
Right push notifications.  I thought there was a separate flag for that, but I don't really know.
Flags: needinfo?(bkelly)
Kit would know if we have a separate pref for Push that needs to be flipped for 52esr.
Flags: needinfo?(kit)
"dom.push.enabled", IIRC.
Flags: needinfo?(kit)
(In reply to Andrea Marchesini [:baku] from comment #5)
> it seems to me that SWs are disabled in ESR-52:
> https://hg.mozilla.org/releases/mozilla-esr52/file/tip/modules/libpref/init/
> all.js#l155

browser/app/profile/firefox.js enables them, afaict.
ESR52 goes to build on Monday, any chance we could have that patch before then?
Flags: needinfo?(amarchesini)
Patch written, I'm waiting to see some results on treeherder
Flags: needinfo?(amarchesini)
Attached patch disable.patch (obsolete) — Splinter Review
Assignee: nobody → amarchesini
Attachment #8840488 - Flags: review?(catalin.badea392)
Comment on attachment 8840488 [details] [diff] [review]
disable.patch

Review of attachment 8840488 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8840488 - Flags: review?(catalin.badea392) → review+
Comment on attachment 8840488 [details] [diff] [review]
disable.patch

We discuss this issue on dev-platform. We are going to do a big refactoring of ServiceWorker code and we cannot port it to ESR52. Better to disable SW now.
Attachment #8840488 - Flags: approval-mozilla-esr52?
Comment on attachment 8840488 [details] [diff] [review]
disable.patch

disable service workers and push notification for esr52
Attachment #8840488 - Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
Attached patch disable.patchSplinter Review
Attachment #8840488 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Verified fixed on 52.0.0esr-build4 using: Windows 7 x64, Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12.3. Push and ServiceWorkers are disabled on 52esr.
Status: RESOLVED → VERIFIED
Blocks: 1457915
You need to log in before you can comment on or make changes to this bug.