Add missing initialisation of DOMParser::mOriginalPrincipleWasSystem

RESOLVED FIXED in Firefox 54

Status

()

Core
DOM
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jseward, Assigned: jseward)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
This is fallout from bug 1336213.  That added a field
DOMParser::mOriginalPrincipleWasSystem but only initialised
it in one of the two constructors for the class.  Use of the
uninitialised field is easily observed with Valgrind, from example
on dom/xslt/tests/mochitest/test_bug427060.html.
(Assignee)

Comment 1

10 months ago
Created attachment 8835528 [details] [diff] [review]
bug1338156-1.cset

The obvious fix.
Attachment #8835528 - Flags: review?(bzbarsky)

Updated

10 months ago
Attachment #8835528 - Flags: review?(bzbarsky) → review+

Comment 2

10 months ago
Thanks for the quick fix!

Comment 3

10 months ago
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d22eeada4c35
Add missing initialisation of DOMParser::mOriginalPrincipleWasSystem.  r=ehsan.

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d22eeada4c35
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.