Closed Bug 1338156 Opened 8 years ago Closed 8 years ago

Add missing initialisation of DOMParser::mOriginalPrincipleWasSystem

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jseward, Assigned: jseward)

References

Details

Attachments

(1 file)

This is fallout from bug 1336213. That added a field DOMParser::mOriginalPrincipleWasSystem but only initialised it in one of the two constructors for the class. Use of the uninitialised field is easily observed with Valgrind, from example on dom/xslt/tests/mochitest/test_bug427060.html.
The obvious fix.
Attachment #8835528 - Flags: review?(bzbarsky)
Attachment #8835528 - Flags: review?(bzbarsky) → review+
Thanks for the quick fix!
Pushed by jseward@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d22eeada4c35 Add missing initialisation of DOMParser::mOriginalPrincipleWasSystem. r=ehsan.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: