Closed
Bug 1338156
Opened 7 years ago
Closed 7 years ago
Add missing initialisation of DOMParser::mOriginalPrincipleWasSystem
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: jseward, Assigned: jseward)
References
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This is fallout from bug 1336213. That added a field DOMParser::mOriginalPrincipleWasSystem but only initialised it in one of the two constructors for the class. Use of the uninitialised field is easily observed with Valgrind, from example on dom/xslt/tests/mochitest/test_bug427060.html.
|
||
Updated•7 years ago
|
Attachment #8835528 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 2•7 years ago
|
||
Thanks for the quick fix!
Pushed by jseward@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d22eeada4c35 Add missing initialisation of DOMParser::mOriginalPrincipleWasSystem. r=ehsan.
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d22eeada4c35
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•