1338166 - <menu>.type should not have "list" as known value

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Simon Pieters [:zcorpan]]

Per HTML standard the values are "toolbar" and "context", where "toolbar" is the invalid value default/missing value default. Gecko also has "list".

This should be tested in reflection test html/dom/elements-misc.js in web-platform-tests as of
https://github.com/w3c/web-platform-tests/pull/4769

Comment 1

[Ben Tian (inactive)]

Attachment: Bug 1338166 - Remove "list" from <menu>.type's known values.

Also set <menu>.type's default value as "toolbar" per HTML spec.

Review commit: https://reviewboard.mozilla.org/r/141774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141774/

Comment 2

[Ben Tian (inactive)]

Comment on attachment 8870315 [details]
Bug 1338166 - Remove "list" from <menu>.type's known values.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141774/diff/1-2/

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8870315 [details]
Bug 1338166 - Remove "list" from <menu>.type's known values.

https://reviewboard.mozilla.org/r/141774/#review146186

Comment 4

[Ben Tian (inactive)]

Comment on attachment 8870315 [details]
Bug 1338166 - Remove "list" from <menu>.type's known values.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141774/diff/2-3/

Comment 5

[Ben Tian (inactive)]

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9a93b46b2d6

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3358d758c15
Remove "list" from <menu>.type's known values. r=qdot

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e3358d758c15

Comment 8

[Julien Cristau [:jcristau]]

This doesn't look like an uplift candidate, wontfix for 54.