1338210 - Set threshold for num_static_constructor alerts to 3

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

Per discussion, 1 is too low. This will also involve allowing tests to express that they want to alert based on the absolute value of the change rather than percentage one, which might also be useful for installer size and build times.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

right now the tests are just noisy, is this fixable?

Comment 3

[William Lachance (:wlach)]

(In reply to Joel Maher ( :jmaher) from comment #2)
> right now the tests are just noisy, is this fixable?

As far as I know, the tests aren't "noisy". It's just expected that this value will churn as people check stuff in.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

then please turn these off, I just spend 15 minutes looking over the last 7 weeks of alerts clearing out alerts with only a delta=1;

Comment 5

[William Lachance (:wlach)]

(In reply to Joel Maher ( :jmaher) from comment #4)
> then please turn these off, I just spend 15 minutes looking over the last 7
> weeks of alerts clearing out alerts with only a delta=1;

I should be able to be able to write the code to set a proper threshold in the next day or so, is that short enough an interval or do you want to turn them off in the interim? Just trying to avoid needless churn.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

next week is fine- this was filed about a month ago, so I wanted to make sure it was on the radar in the shorter term.

Comment 7

[William Lachance (:wlach)]

Attachment: Bug 1338210 - Set threshold for num_static_constructor alerts to 3

Review commit: https://reviewboard.mozilla.org/r/119188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119188/

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8846111 [details]
Bug 1338210 - Set threshold for num_static_constructor alerts to 3

https://reviewboard.mozilla.org/r/119188/#review121174

thanks :wlach

Comment 9

[William Lachance (:wlach)]

The treeherder changes to support this have just landed on production, so we can apply this change.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/021a93e70971
Set threshold for num_static_constructor alerts to 3 r=jmaher

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/021a93e70971