1338274 - Remove the now-unused code with renderer thread

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: remove the codes with MOZ_USE_RENDER_THREAD condition.

MozReview-Commit-ID: 5Jij2RRk86X

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: remove the usage of WrWindowState, Compositor and GLContext in WebRenderBridgeParent.

MozReview-Commit-ID: CKK9cBLlYnh

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: clean up webrender_binding.

MozReview-Commit-ID: 4TdnTXjzo52

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: remove MOZ_USE_RENDER_THREAD def.

MozReview-Commit-ID: 8UrioLOq37Z

Comment 5

[Jerry Shih[:jerry] (UTC+8) (inactive)]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd142ca07f8e149922e333cc6a6b35ad7f433aab

Comment 6

[Nicolas Silva [:nical]]

Comment on attachment 8835708 [details] [diff] [review]
remove the codes with MOZ_USE_RENDER_THREAD condition.

Review of attachment 8835708 [details] [diff] [review]:
-----------------------------------------------------------------

Magnificient!

Comment 7

[Nicolas Silva [:nical]]

Comment on attachment 8835709 [details] [diff] [review]
remove the usage of WrWindowState, Compositor and GLContext in WebRenderBridgeParent.

Review of attachment 8835709 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderBridgeParent.cpp
@@ +528,5 @@
>  
> +  MOZ_ASSERT(mApi);
> +  // TODO(bug 1328602) With the RenderThread, calling SetRootStackingContext
> +  // should trigger the composition on the render thread.
> +  return;

no need to return just before the end of the function, and likewise no need to have the early return branches above. We should just make it an empty function and maybe see if we can remove it entirely (we inherit it form some parent interface so maybe we'll have to settle with an empty function).

Comment 8

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: remove the usage of WrWindowState, Compositor and GLContext in WebRenderBridgeParent. v2, r=nical

Turn to have an MOZ_ASSERT_UNREACHABLE() in WebRenderBridgeParent::CompositeToTarget()

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/e84aba0ef520
remove the codes with MOZ_USE_RENDER_THREAD condition. r=nical
https://hg.mozilla.org/projects/graphics/rev/020ec1ae24f5
remove the usage of WrWindowState, Compositor and GLContext in WebRenderBridgeParent. r=nical
https://hg.mozilla.org/projects/graphics/rev/2c0dc842fe93
clean up webrender_binding. r=nical
https://hg.mozilla.org/projects/graphics/rev/764e2c0ad987
remove MOZ_USE_RENDER_THREAD def. r=nical