Closed Bug 1338274 Opened 3 years ago Closed 3 years ago

Remove the now-unused code with renderer thread

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: jerry, Assigned: jerry)

References

Details

Attachments

(4 files, 1 obsolete file)

No description provided.
Blocks: 1338285
MozReview-Commit-ID: 5Jij2RRk86X
Attachment #8835708 - Flags: review?(nical.bugzilla)
MozReview-Commit-ID: CKK9cBLlYnh
Attachment #8835709 - Flags: review?(nical.bugzilla)
MozReview-Commit-ID: 4TdnTXjzo52
Attachment #8835710 - Flags: review?(nical.bugzilla)
MozReview-Commit-ID: 8UrioLOq37Z
Attachment #8835711 - Flags: review?(nical.bugzilla)
Comment on attachment 8835708 [details] [diff] [review]
remove the codes with MOZ_USE_RENDER_THREAD condition.

Review of attachment 8835708 [details] [diff] [review]:
-----------------------------------------------------------------

Magnificient!
Attachment #8835708 - Flags: review?(nical.bugzilla) → review+
Comment on attachment 8835709 [details] [diff] [review]
remove the usage of WrWindowState, Compositor and GLContext in WebRenderBridgeParent.

Review of attachment 8835709 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderBridgeParent.cpp
@@ +528,5 @@
>  
> +  MOZ_ASSERT(mApi);
> +  // TODO(bug 1328602) With the RenderThread, calling SetRootStackingContext
> +  // should trigger the composition on the render thread.
> +  return;

no need to return just before the end of the function, and likewise no need to have the early return branches above. We should just make it an empty function and maybe see if we can remove it entirely (we inherit it form some parent interface so maybe we'll have to settle with an empty function).
Attachment #8835709 - Flags: review?(nical.bugzilla) → review+
Attachment #8835710 - Flags: review?(nical.bugzilla) → review+
Attachment #8835711 - Flags: review?(nical.bugzilla) → review+
Turn to have an MOZ_ASSERT_UNREACHABLE() in WebRenderBridgeParent::CompositeToTarget()
Attachment #8836067 - Attachment description: Update for comment 7. → remove the usage of WrWindowState, Compositor and GLContext in WebRenderBridgeParent. v2, r=nical
Attachment #8835709 - Attachment is obsolete: true
Pushed by hshih@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/e84aba0ef520
remove the codes with MOZ_USE_RENDER_THREAD condition. r=nical
https://hg.mozilla.org/projects/graphics/rev/020ec1ae24f5
remove the usage of WrWindowState, Compositor and GLContext in WebRenderBridgeParent. r=nical
https://hg.mozilla.org/projects/graphics/rev/2c0dc842fe93
clean up webrender_binding. r=nical
https://hg.mozilla.org/projects/graphics/rev/764e2c0ad987
remove MOZ_USE_RENDER_THREAD def. r=nical
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.