Closed Bug 1338309 Opened 9 years ago Closed 8 years ago

Gmail complains that cookies are disabled in e10s windows

Categories

(Core :: Networking: Cookies, defect, P2)

54 Branch
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
platform-rel --- +
firefox54 --- affected

People

(Reporter: glasserc, Assigned: amchung)

Details

(Whiteboard: [necko-next][platform-rel-Google][platform-rel-Gmail])

Attachments

(1 file)

I just switched to Nightly for my main browsing and I can't log into Gmail, either with my personal or my corporate account. I get redirected to https://mail.google.com/mail/u/0/?view=nocookies . I'm able to log into calendar.google.com. I'm also running the Self-Destructing Cookies add-on, but I have google.com whitelisted, and even when I disable the add-on, I get the same behavior. Opening a non-e10s window allows me to log into Gmail correctly.
I can sign in to gmail on yesterday's Nightly with e10s enabled. I'm on Windows 10, and Firefox is set to use more than 2 content processes. I'll update to today's Nightly and see if something breaks.
Nope, current Nightly signs in just fine, too. Wondering if it's a sandboxing thing, since you're on Linux? If you switched to Nightly, are you using the same profile that you used for release Firefox? Maybe permissions for the cookies database changed in some incompatible way. Try clearing all of your cookies, or launching Nightly with a new profile?
Attached file permissions.sqlite
I already tried clearing just Google cookies, and that didn't seem to fix it. Running Nightly with a new profile seems to work OK (lets me log in to Gmail without problems). Going back to the old profile and using the Prefs "clear recent history" to clear "Everything" from "Cookies" doesn't resolve the problem. Doing `rm /path/to/cookies.sqlite` doesn't seem to resolve the problem. By copying over individual files from the old "broken" profile and the new "working" profile, I was able to narrow it down to `permissions.sqlite`. Removing it from the profile causes the profile to start working, and putting it back causes it to break. I've attached the file. Before switching to Nightly, I think I was on 50.1.0. I'm not sure if jumping to 54 was too big a jump :)
I believe it is ACCESS_ALLOW_FIRST_PARTY_ONLY: https://dxr.mozilla.org/mozilla-central/source/netwerk/cookie/nsICookiePermission.idl#33. From looking around a little bit at the code, it seems the Self-Destructing Cookies add-on uses this value (among others) as part of its whitelist for domains that can leave cookies that survive the closing of the browser tab.
Is this a problem of Self-Destructing Cookies add-on? Is it working if you disable it?
No, as I wrote in comment #0, disabling the add-on does not by itself fix the problem. However, I do think the add-on is responsible for putting the permission in `permissions.sqlite`.
Does that restriction stay in the permissions table if you disable self-destructing cookies? If so, what happens if you leave the add-on disabled *and* remove those restrictions manually?
Flags: needinfo?(eglassercamp)
Yes, all restrictions in the permissions table remain even when you disable the Self-Destructing Cookies add-on. This is why I still couldn't log in to Gmail in comment 0. Removing the restrictions manually is enough to let me log in to Gmail, regardless of whether or not I disable the plugin.
Flags: needinfo?(eglassercamp)
Well, this is fun. Sounds like there's a couple issues here. First, seems like self-destructing cookies should be removing the restrictions it adds when it's disabled/uninstalled (do add-ons even have the ability to do that?). But there definitely seems to be a necko and/or permissions issue at hand, since this only happens in e10s windows. Jason, don't we have some people in Taipei that have been poking at cookies lately that might be able to dig into this more?
Flags: needinfo?(jduell.mcbugs)
Whiteboard: [necko-next]
Amy, please take a look at this issue, thanks.
Assignee: nobody → amchung
Flags: needinfo?(jduell.mcbugs)
Priority: -- → P2
platform-rel: --- → ?
Whiteboard: [necko-next] → [necko-next][platform-rel-Google][platform-rel-Gmail]
platform-rel: ? → +
I have the same problem as the comment 0 after I manually enabled e10s after I installed firefox 53. I tried several tweaks: 1. disable self-destructed cookie addon, not working 2. safe mode, not working 3. refresh firefox, working without e10s enabled by default, not working with e10s enabled 4. manually add https://google.com to whitelist of self-destructed cookie with allow all option <----working! I did not test refresh firefox without self-destructed cookie installed. Hope my report would help.
Hi Ethan, I can't reproduce this issue, and my reproducing steps as below: 1. Used firefox 54. 2. Installed Self-Destructing Cookies add-on. 3. Opened e10s. 4. Tried to log-in gmail. Would you help me to confirm the steps? And does the behavior of this bug also occur on nightly 56? Thanks!
Flags: needinfo?(eglassercamp)
Hi Amy, this behavior stopped happening for me at some point but I don't know when. Using Nightly 56, this behavior doesn't occur, possibly because the Self-Destructing Cookies add-on is not e10s compatible. I checked `permissions.sqlite` and it seems like the google.com `cookie` rows are gone. I'm not sure what (if anything) this means. As far as I'm concerned, I guess this can be closed.
Flags: needinfo?(eglassercamp)
Ok, Thanks!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: