1338417 - @@iterator (Symbol.iterator) properties on DOM interfaces should not be enumerable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now we have them enumerable.  Once web platform tests sync this will cause some test failures, for example on url/interfaces.html.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make @@iterator properties on DOM prototypes not enumerable, to match IDL spec

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8835849 [details] [diff] [review]
Make @@iterator properties on DOM prototypes not enumerable, to match IDL spec

Review of attachment 8835849 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +3084,1 @@
>                      # XXX If we ever create non-enumerable properties that can

nit: looks like your comment indentation may've gone a bit off here.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> nit: looks like your comment indentation may've gone a bit off here.

I don't think it has... that comment applies only to the "else" case of that if/elif/else: the "if" is @@iterator and always non-enumerable, and the "elif" just throws.  The "else" case is the only one where interesting enumFlags could happen.

I will move the comment to right _before_ we set enumFlags to make that clearer.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcb87a45ab4a
Make @@iterator properties on DOM prototypes not enumerable, to match IDL spec.  r=qdot

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fcb87a45ab4a