Closed Bug 1338417 Opened 5 years ago Closed 5 years ago

@@iterator (Symbol.iterator) properties on DOM interfaces should not be enumerable

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Right now we have them enumerable.  Once web platform tests sync this will cause some test failures, for example on url/interfaces.html.
Comment on attachment 8835849 [details] [diff] [review]
Make @@iterator properties on DOM prototypes not enumerable, to match IDL spec

Review of attachment 8835849 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +3084,1 @@
>                      # XXX If we ever create non-enumerable properties that can

nit: looks like your comment indentation may've gone a bit off here.
Attachment #8835849 - Flags: review?(kyle) → review+
> nit: looks like your comment indentation may've gone a bit off here.

I don't think it has... that comment applies only to the "else" case of that if/elif/else: the "if" is @@iterator and always non-enumerable, and the "elif" just throws.  The "else" case is the only one where interesting enumFlags could happen.

I will move the comment to right _before_ we set enumFlags to make that clearer.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcb87a45ab4a
Make @@iterator properties on DOM prototypes not enumerable, to match IDL spec.  r=qdot
https://hg.mozilla.org/mozilla-central/rev/fcb87a45ab4a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.