Closed Bug 1338438 Opened 8 years ago Closed 8 years ago

Test interfaces on both http and https channels

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: shawnjohnjr, Assigned: shawnjohnjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [storage-v1])

Attachments

(1 file, 3 obsolete files)

Follow up Bug 1268804 Comment 88. Test test_interfaces, test_worker_interfaces, test_worker_interfaces on both http and https channel. 'So specifically, we should pull all the script out of test_interfaces and test_worker_interfaces and test_navigator out into external scripts. Then we should have two versions of each test, one loaded over https and one not, linking to said external scripts. Then we should have the test assertions assert that some things are visible only in the secure context version.'
Summary: Test test_interfaces, test_worker_interfaces, test_worker_interfaces on both http and https channel → Test interfaces on both http and https channels
(In reply to Shawn Huang [:shawnjohnjr] from comment #4) > Comment on attachment 8835881 [details] [diff] [review] > Bug 1338438 - Test interfaces on both http and https channels > > Review of attachment 8835881 [details] [diff] [review]: > ----------------------------------------------------------------- > > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=050bf7ecac7982e70090784e658fc75e959ada1e It looks good.
Comment on attachment 8835881 [details] [diff] [review] Bug 1338438 - Test interfaces on both http and https channels Please use "hg copy" (followed by removal of the non-JS bits) to create the *.js files so we don't lose revision history. That will also make it _much_ simpler to tell whether you're introducing any changes in the JS bits. ;)
Attachment #8835881 - Flags: review?(bzbarsky) → review-
Comment on attachment 8836462 [details] [diff] [review] Bug 1338438 - Test interfaces on both http and https channels Review of attachment 8836462 [details] [diff] [review]: ----------------------------------------------------------------- Hi bz, Thanks for pointing out the problems. I've used 'hg copy' to create test_interfaces.js and test_navigator.js.
Attachment #8836462 - Flags: review?(bzbarsky)
Comment on attachment 8836462 [details] [diff] [review] Bug 1338438 - Test interfaces on both http and https channels Thank you, this is much easier to review. ;) >+++ b/dom/tests/mochitest/general/test_interfaces.html So what you should probably do is have this test do: ok(!self.isSecureContext, "This test should not be running in a secure context"); in addition to loading test_interfaces.js. >+++ b/dom/tests/mochitest/general/test_interfaces_secureContext.html And this one should do: ok(self.isSecureContext, "This test should be running in a secure context"); >+++ b/dom/workers/test/test_navigator.html >+++ b/dom/workers/test/test_navigator_secureContext.html And here. And maybe a followup to have the worker for this test check self.isSecureContext in the worker too? >+++ b/dom/workers/test/test_worker_interfaces_secureContext.html And for this one as well, test_worker_interfaces.js should be able make assertions about secure context state based on where it got loaded from. Again, followup is ok for this part. r=me
Attachment #8836462 - Flags: review?(bzbarsky) → review+
Assignee: nobody → shuang
Pushed by shuang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1f71852f5f Test interfaces on both http and https channels, r=bz
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Whiteboard: [storage-v1]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: