1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

When looking at the analysis of event telemetry we noticed 2 things:

* If the same command is sent to multiple clients, they should all use the same "flowID" so we can identify them as being from a single event.

* Some commands (eg, "resetClient") are sent for a number of reasons - it would be useful to know what that reason is.

Event telemetry landed in bug 1289536, so we should uplift this bug to 53 once it lands so all event telemetry on the release channel has this capability.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands.

Review commit: https://reviewboard.mozilla.org/r/111436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111436/

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8835867 [details]
Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands.

https://reviewboard.mozilla.org/r/111436/#review112964

Looks good to me!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61b9b8da134c
Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands. r=tcsc

Comment 4

[Mark Hammond [:markh] [:mhammond]]

ni myself to request uploft

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/383dce08a941
followup, placate eslint

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/61b9b8da134c
https://hg.mozilla.org/mozilla-central/rev/383dce08a941

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8835867 [details]
Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1289536 introduced the feature
[User impact if declined]: Telemetry analysis of various sync functionality will be difficult to obtain.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes, manually
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Risk is limited to "send tab to device" functionality in Sync
[String changes made/needed]: None

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8835867 [details]
Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands.

Fix a sync telemetry issue to multiple clients and test is added. Aurora53+.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/002105261cee
https://hg.mozilla.org/releases/mozilla-aurora/rev/364d760583b3