Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Sync
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: markh, Assigned: markh)

Tracking

unspecified
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox53 fixed, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
When looking at the analysis of event telemetry we noticed 2 things:

* If the same command is sent to multiple clients, they should all use the same "flowID" so we can identify them as being from a single event.

* Some commands (eg, "resetClient") are sent for a number of reasons - it would be useful to know what that reason is.

Event telemetry landed in bug 1289536, so we should uplift this bug to 53 once it lands so all event telemetry on the release channel has this capability.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8835867 [details]
Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands.

https://reviewboard.mozilla.org/r/111436/#review112964

Looks good to me!
Attachment #8835867 - Flags: review?(tchiovoloni) → review+

Comment 3

a year ago
Pushed by mhammond@skippinet.com.au:
https://hg.mozilla.org/integration/autoland/rev/61b9b8da134c
Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands. r=tcsc
(Assignee)

Comment 4

a year ago
ni myself to request uploft
Flags: needinfo?(markh)

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/61b9b8da134c
https://hg.mozilla.org/mozilla-central/rev/383dce08a941
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
(Assignee)

Comment 7

a year ago
Comment on attachment 8835867 [details]
Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1289536 introduced the feature
[User impact if declined]: Telemetry analysis of various sync functionality will be difficult to obtain.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes, manually
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Risk is limited to "send tab to device" functionality in Sync
[String changes made/needed]: None
Flags: needinfo?(markh)
Attachment #8835867 - Flags: approval-mozilla-aurora?
status-firefox53: --- → affected
Comment on attachment 8835867 [details]
Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands.

Fix a sync telemetry issue to multiple clients and test is added. Aurora53+.
Attachment #8835867 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.