1338523 - Crash in mozilla::ipc::PrincipalInfo::AssertSanity

Status: RESOLVED DUPLICATE of bug 1337522

(Core :: Storage: IndexedDB, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-89982a69-2602-4508-96e9-db3812170209.
=============================================================

Seen while looking at nightly crash stats - crashes started with 20170208030203 build: http://bit.ly/2lyaGps

Possible regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af8a2573d0f1e9cc6f2ba0ab67d7a702a197f177&tochange=3a95aa4246653a7863914ffec032897d13359fb0

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

This is most likely due to bug 1333573.  I'd like to fix bug 1337522 first and see if it helps here.

Comment 2

[Marcia Knous [:marcia]]

Adding a similar signature since it shows up with the same regression range.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

[Tracking Requested - why for this release]:

Let's make sure we don't release this crash regression.

Comment 4

[Marcia Knous [:marcia]]

Tracking 54+ for this crash regression.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

This could be because we assume the PrincipalToPrincipalInfo() always succeeds.  This may not be the case under OOM conditions, etc.  Lets try making it fallible and see if the crashes go away.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Make worker SetPrincipalOnMainThread fallible. r=baku

My best guess is that the PrincipalToPrincipalInfo() call is failing, but we just ignore it in non-DEBUG builds.  There are a lot of error returns in that method, so its probably not reasonable to assume success in all cases.

https://dxr.mozilla.org/mozilla-central/source/ipc/glue/BackgroundUtils.cpp#132

Lets make SetPrincipalOnMainThread() fallible so we can properly handle any errors.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=162bb60cb7c1275cf441bcdb75e5ba60287b0df9

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21e33ec545a1
Make worker SetPrincipalOnMainThread fallible. r=baku

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

Let's leave this open until we see if the crashes are helped by comment 7 commit.

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88674db2fe97
Backout 959dce51f8cb for incorrect bug number in commit message. r=me

Comment 10

[Ben Kelly [:bkelly, not reviewing]]

Note comment 9 backout was prior to comment 7.  I accidentally landed this with the wrong bug number and had to fix it.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/21e33ec545a1

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

This was last seen in build id 20170214030231.  So it appears bug 1337522 fixed it.

Comment 13

[Ben Kelly [:bkelly, not reviewing]]

This was fixed in bug 1337522.

Comment 14

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.