If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Move check_mkdir.tpy to PYTHON_UNIT_TESTS

RESOLVED FIXED in Firefox 54

Status

()

Core
Build Config
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: mshal, Assigned: mshal)

Tracking

(Blocks: 1 bug)

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

7 months ago
I'm not sure if this test is still relevant, but it seems to work fine by putting it into the python.ini file rather than having a Makefile.in dedicated to it.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

7 months ago
mozreview-review
Comment on attachment 8836153 [details]
Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest;

https://reviewboard.mozilla.org/r/111596/#review112996

::: config/tests/python.ini:6
(Diff revision 1)
>  [test_mozbuild_reading.py]
>  [unit-expandlibs.py]
>  [unit-mozunit.py]
>  [unit-nsinstall.py]
>  [unit-printprereleasesuffix.py]
> +[makefiles/autodeps/check_mkdir.tpy]

`.tpy`?
Attachment #8836153 - Flags: review?(cmanchester) → review+

Comment 4

7 months ago
mozreview-review
Comment on attachment 8836154 [details]
Bug 1338608 - Use mozunit in check_mkdir.py;

https://reviewboard.mozilla.org/r/111598/#review112998
Attachment #8836154 - Flags: review?(cmanchester) → review+
(Assignee)

Comment 5

7 months ago
(In reply to Chris Manchester (Away Feb 11-15) from comment #3)
> > +[makefiles/autodeps/check_mkdir.tpy]
> 
> `.tpy`?

Beats me :). I can change it to .py if you like.
(In reply to Michael Shal [:mshal] from comment #5)
> (In reply to Chris Manchester (Away Feb 11-15) from comment #3)
> > > +[makefiles/autodeps/check_mkdir.tpy]
> > 
> > `.tpy`?
> 
> Beats me :). I can change it to .py if you like.

Sure, let's change it to .py while we're here.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 11

7 months ago
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/007864924aeb
Move check_mkdir.tpy into a python unittest manifest; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/002f04770d29
Use mozunit in check_mkdir.py; r=chmanchester

Comment 12

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/007864924aeb
https://hg.mozilla.org/mozilla-central/rev/002f04770d29
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.