1338608 - Move check_mkdir.tpy to PYTHON_UNIT_TESTS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

I'm not sure if this test is still relevant, but it seems to work fine by putting it into the python.ini file rather than having a Makefile.in dedicated to it.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest;

Review commit: https://reviewboard.mozilla.org/r/111596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111596/

Comment 2

[Michael Shal [:mshal]]

Attachment: Bug 1338608 - Use mozunit in check_mkdir.py;

This makes the check_mkdir.tpy match the TEST-PASS output of other tests
in the suite.

Review commit: https://reviewboard.mozilla.org/r/111598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111598/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8836153 [details]
Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest;

https://reviewboard.mozilla.org/r/111596/#review112996

::: config/tests/python.ini:6
(Diff revision 1)
>  [test_mozbuild_reading.py]
>  [unit-expandlibs.py]
>  [unit-mozunit.py]
>  [unit-nsinstall.py]
>  [unit-printprereleasesuffix.py]
> +[makefiles/autodeps/check_mkdir.tpy]

`.tpy`?

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8836154 [details]
Bug 1338608 - Use mozunit in check_mkdir.py;

https://reviewboard.mozilla.org/r/111598/#review112998

Comment 5

[Michael Shal [:mshal]]

(In reply to Chris Manchester (Away Feb 11-15) from comment #3)
> > +[makefiles/autodeps/check_mkdir.tpy]
> 
> `.tpy`?

Beats me :). I can change it to .py if you like.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

(In reply to Michael Shal [:mshal] from comment #5)
> (In reply to Chris Manchester (Away Feb 11-15) from comment #3)
> > > +[makefiles/autodeps/check_mkdir.tpy]
> > 
> > `.tpy`?
> 
> Beats me :). I can change it to .py if you like.

Sure, let's change it to .py while we're here.

Comment 7

[Michael Shal [:mshal]]

Comment on attachment 8836153 [details]
Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111596/diff/1-2/

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 8836154 [details]
Bug 1338608 - Use mozunit in check_mkdir.py;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111598/diff/1-2/

Comment 9

[Michael Shal [:mshal]]

Comment on attachment 8836153 [details]
Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111596/diff/2-3/

Comment 10

[Michael Shal [:mshal]]

Comment on attachment 8836154 [details]
Bug 1338608 - Use mozunit in check_mkdir.py;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111598/diff/2-3/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/007864924aeb
Move check_mkdir.tpy into a python unittest manifest; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/002f04770d29
Use mozunit in check_mkdir.py; r=chmanchester

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/007864924aeb
https://hg.mozilla.org/mozilla-central/rev/002f04770d29