Closed
Bug 1338608
Opened 8 years ago
Closed 8 years ago
Move check_mkdir.tpy to PYTHON_UNIT_TESTS
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: mshal, Assigned: mshal)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
I'm not sure if this test is still relevant, but it seems to work fine by putting it into the python.ini file rather than having a Makefile.in dedicated to it.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8836153 [details]
Bug 1338608 - Move check_mkdir.tpy into a python unittest manifest;
https://reviewboard.mozilla.org/r/111596/#review112996
::: config/tests/python.ini:6
(Diff revision 1)
> [test_mozbuild_reading.py]
> [unit-expandlibs.py]
> [unit-mozunit.py]
> [unit-nsinstall.py]
> [unit-printprereleasesuffix.py]
> +[makefiles/autodeps/check_mkdir.tpy]
`.tpy`?
Attachment #8836153 -
Flags: review?(cmanchester) → review+
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8836154 [details]
Bug 1338608 - Use mozunit in check_mkdir.py;
https://reviewboard.mozilla.org/r/111598/#review112998
Attachment #8836154 -
Flags: review?(cmanchester) → review+
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Chris Manchester (Away Feb 11-15) from comment #3)
> > +[makefiles/autodeps/check_mkdir.tpy]
>
> `.tpy`?
Beats me :). I can change it to .py if you like.
Comment 6•8 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #5)
> (In reply to Chris Manchester (Away Feb 11-15) from comment #3)
> > > +[makefiles/autodeps/check_mkdir.tpy]
> >
> > `.tpy`?
>
> Beats me :). I can change it to .py if you like.
Sure, let's change it to .py while we're here.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 11•8 years ago
|
||
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/007864924aeb
Move check_mkdir.tpy into a python unittest manifest; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/002f04770d29
Use mozunit in check_mkdir.py; r=chmanchester
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/007864924aeb
https://hg.mozilla.org/mozilla-central/rev/002f04770d29
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•