Closed Bug 1338889 Opened 3 years ago Closed 3 years ago

Error when opening directory tree on the WebUI of the file station QNAP QGenie QG-103

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
x86_64
Windows 10
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox51 --- wontfix
firefox52 --- fixed
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: gaetan.t, Assigned: jdai)

References

()

Details

(Keywords: regression)

Attachments

(7 files, 2 obsolete files)

68.66 KB, application/pdf
Details
12.05 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
8.51 KB, patch
jdai
: review+
Details | Diff | Splinter Review
12.01 KB, patch
jdai
: review+
Details | Diff | Splinter Review
8.54 KB, patch
jdai
: review+
Details | Diff | Splinter Review
11.87 KB, patch
jdai
: review+
Details | Diff | Splinter Review
5.86 KB, patch
jdai
: review+
Details | Diff | Splinter Review
Attached file Firefox Bug.docx (obsolete) —
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

Acces File Station Lite in QNAP QGenie QG-103


Actual results:

TypeError: Argument 3 of Document.createElement can't be converted to a dictionary.


Expected results:

Display Directory Tree with files.
Works correctly with MS-Edge, Chrome or IOS Safari.
To reproduce:

Login as Guest, click on "File Station Lite" than try to open the directory tree.
OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64
Attached file Firefox Bug.pdf
Attachment #8836463 - Attachment is obsolete: true
Reg range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=db0243f476257
6ce4874d56bd3c92c56fcf78ab7&tochange=fc1d44b2cb7b7d7c47a365bddfc23ff991505003  

Jocelyn Liu — Bug 1276579: Add 'options' argument into |document.createElement[NS]()| methods and remove overloaded |createElement[NS]()| methods. r=smaug,wchen


It could be a Tech Evangelism bug.

wchen, what do you think?
Blocks: 1276579
Component: Untriaged → DOM
Flags: needinfo?(wchen)
Keywords: regression
Product: Firefox → Core
Summary: TypeError: Argument 3 of Document.createElement can't be converted to a dictionary. → Error when opening directory tree on the WebUI of the file station QNAP QGenie QG-103
Version: 51 Branch → 50 Branch
We have fixed similar issue on Document.createElement in bug 1294100, look like we need to do the same change in Document.createElementNS.

i.e.
  Element createElementNS(DOMString? namespace, DOMString qualifiedName, optional (ElementCreationOptions or DOMString) options);
There's still time to get a low-risk fix for this into Fx52, but that window is rapidly closing. Given comment 4, do you have time to look into this, John?
Assignee: nobody → jdai
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(wchen)
Flags: needinfo?(jdai)
Attachment #8837442 - Flags: review?(bzbarsky)
Hi bz,
In this patch, I applied the same changes as Document.createElement in bug 1294100.
I have tested on my local via comment #1. Could you help me review this patches? Thank you.

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1e180897a19b72930ed9f1a1b3ffe32691ddf5a&filter-tier=1&group_state=expanded
Attachment #8837445 - Flags: review?(bzbarsky)
Comment on attachment 8837442 [details] [diff] [review]
Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz

r=me.  Thank you for pulling this out into a separate changeset!
Attachment #8837442 - Flags: review?(bzbarsky) → review+
Comment on attachment 8837445 [details] [diff] [review]
Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS.

>+  ElementCreationOptionsOrString options;
>+
>+  options.SetAsString();

It would be better to have the blank line after the SetAsString() call, like so:

+  ElementCreationOptionsOrString options;
+  options.SetAsString();
+

and the same thing at the other SetAsString() callsites in this patch.

r=me with that.
Attachment #8837445 - Flags: review?(bzbarsky) → review+
Attachment #8837442 - Attachment description: Bug 1338889 - Part 1: Remove redundant trailing spaces. → Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz
Addressed comment #9 and carry r+.
Attachment #8837445 - Attachment is obsolete: true
Attachment #8837460 - Flags: review+
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b2b7bf67ff7
Part 1: Remove redundant trailing spaces. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fe1c0398178
Part 2: Support DOMString as Argument 3 of Document.createElementNS. r=bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8b2b7bf67ff7
https://hg.mozilla.org/mozilla-central/rev/1fe1c0398178
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Thanks for jumping on this so fast, John! Please request Aurora/Beta approval on this when you get a chance.
Flags: needinfo?(jdai)
Gaetan, thanks for the report! The fix for this bug should be in tomorrow's Firefox 54 Nightly build if you'd like to verify that it's working as expected.
https://www.mozilla.org/firefox/channel/desktop/

If all goes well, we'll be able to backport the fix to Firefox 52 as well for one of the upcoming Beta releases.
Flags: needinfo?(gaetan.t)
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1338889
[User impact if declined]: Document.createElementNS can't work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: See comment #1.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This simply applied same changes from Document.createElement.
[String changes made/needed]: None.
Flags: needinfo?(jdai)
Attachment #8837973 - Flags: review+
Attachment #8837973 - Flags: approval-mozilla-aurora?
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1338889
[User impact if declined]: Document.createElementNS can't work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: See comment #1.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This simply applied same changes from Document.createElement.
[String changes made/needed]: None.
Attachment #8837974 - Flags: review+
Attachment #8837974 - Flags: approval-mozilla-aurora?
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1338889
[User impact if declined]: Document.createElementNS can't work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: See comment #1.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This simply applied same changes from Document.createElement.
[String changes made/needed]: None.
Attachment #8837975 - Flags: review+
Attachment #8837975 - Flags: approval-mozilla-beta?
Approval Request Comment
[Feature/Bug causing the regression]: Bug 1338889
[User impact if declined]: Document.createElementNS can't work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: See comment #1.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This simply applied same changes from Document.createElement.
[String changes made/needed]: None.
Attachment #8837977 - Flags: review+
Attachment #8837977 - Flags: approval-mozilla-beta?
Comment on attachment 8837975 [details] [diff] [review]
(Beta) Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz

whitespace...
Attachment #8837975 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8837973 [details] [diff] [review]
(Aurora) Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz

whitespace changes
Attachment #8837973 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8837974 [details] [diff] [review]
(Aurora) Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS. r=bz

Document.createElementNS fix for aurora53

Should dom/tests/mochitest/webcomponents/test_document_register.html be extended to cover this case?
Attachment #8837974 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8837977 [details] [diff] [review]
(Beta) Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS. r=bz

fix for Document.createElementNS, beta52+
Attachment #8837977 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(gaetan.t)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.