1338889 - Error when opening directory tree on the WebUI of the file station QNAP QGenie QG-103

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gaetan Tremblay]

Attachment: Firefox Bug.docx

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

Acces File Station Lite in QNAP QGenie QG-103


Actual results:

TypeError: Argument 3 of Document.createElement can't be converted to a dictionary.


Expected results:

Display Directory Tree with files.
Works correctly with MS-Edge, Chrome or IOS Safari.

Comment 1

[Gaetan Tremblay]

To reproduce:

Login as Guest, click on "File Station Lite" than try to open the directory tree.

Comment 2

[Loic]

Attachment: Firefox Bug.pdf

Comment 3

[Loic]

Reg range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=db0243f476257
6ce4874d56bd3c92c56fcf78ab7&tochange=fc1d44b2cb7b7d7c47a365bddfc23ff991505003  

Jocelyn Liu — Bug 1276579: Add 'options' argument into |document.createElement[NS]()| methods and remove overloaded |createElement[NS]()| methods. r=smaug,wchen


It could be a Tech Evangelism bug.

wchen, what do you think?

Comment 4

[Edgar Chen [:edgar]]

We have fixed similar issue on Document.createElement in bug 1294100, look like we need to do the same change in Document.createElementNS.

i.e.
  Element createElementNS(DOMString? namespace, DOMString qualifiedName, optional (ElementCreationOptions or DOMString) options);

Comment 5

[Ryan VanderMeulen [:RyanVM]]

There's still time to get a low-risk fix for this into Fx52, but that window is rapidly closing. Given comment 4, do you have time to look into this, John?

Comment 6

[John Dai[:jdai]]

Attachment: Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz

Comment 7

[John Dai[:jdai]]

Attachment: Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS.

Hi bz,
In this patch, I applied the same changes as Document.createElement in bug 1294100.
I have tested on my local via comment #1. Could you help me review this patches? Thank you.

Try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1e180897a19b72930ed9f1a1b3ffe32691ddf5a&filter-tier=1&group_state=expanded

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8837442 [details] [diff] [review]
Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz

r=me.  Thank you for pulling this out into a separate changeset!

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8837445 [details] [diff] [review]
Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS.

>+  ElementCreationOptionsOrString options;
>+
>+  options.SetAsString();

It would be better to have the blank line after the SetAsString() call, like so:

+  ElementCreationOptionsOrString options;
+  options.SetAsString();
+

and the same thing at the other SetAsString() callsites in this patch.

r=me with that.

Comment 10

[John Dai[:jdai]]

Attachment: Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS. r=bz

Addressed comment #9 and carry r+.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b2b7bf67ff7
Part 1: Remove redundant trailing spaces. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fe1c0398178
Part 2: Support DOMString as Argument 3 of Document.createElementNS. r=bz

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8b2b7bf67ff7
https://hg.mozilla.org/mozilla-central/rev/1fe1c0398178

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Thanks for jumping on this so fast, John! Please request Aurora/Beta approval on this when you get a chance.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Gaetan, thanks for the report! The fix for this bug should be in tomorrow's Firefox 54 Nightly build if you'd like to verify that it's working as expected.
https://www.mozilla.org/firefox/channel/desktop/

If all goes well, we'll be able to backport the fix to Firefox 52 as well for one of the upcoming Beta releases.

Comment 15

[John Dai[:jdai]]

Attachment: (Aurora) Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1338889
[User impact if declined]: Document.createElementNS can't work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: See comment #1.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This simply applied same changes from Document.createElement.
[String changes made/needed]: None.

Comment 16

[John Dai[:jdai]]

Attachment: (Aurora) Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS. r=bz

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1338889
[User impact if declined]: Document.createElementNS can't work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: See comment #1.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This simply applied same changes from Document.createElement.
[String changes made/needed]: None.

Comment 17

[John Dai[:jdai]]

Attachment: (Beta) Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1338889
[User impact if declined]: Document.createElementNS can't work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: See comment #1.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This simply applied same changes from Document.createElement.
[String changes made/needed]: None.

Comment 18

[John Dai[:jdai]]

Attachment: (Beta) Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS. r=bz

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1338889
[User impact if declined]: Document.createElementNS can't work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: See comment #1.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This simply applied same changes from Document.createElement.
[String changes made/needed]: None.

Comment 19

[Julien Cristau [:jcristau]]

Comment on attachment 8837975 [details] [diff] [review]
(Beta) Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz

whitespace...

Comment 20

[Julien Cristau [:jcristau]]

Comment on attachment 8837973 [details] [diff] [review]
(Aurora) Bug 1338889 - Part 1: Remove redundant trailing spaces. r=bz

whitespace changes

Comment 21

[Julien Cristau [:jcristau]]

Comment on attachment 8837974 [details] [diff] [review]
(Aurora) Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS. r=bz

Document.createElementNS fix for aurora53

Should dom/tests/mochitest/webcomponents/test_document_register.html be extended to cover this case?

Comment 22

[Julien Cristau [:jcristau]]

Comment on attachment 8837977 [details] [diff] [review]
(Beta) Bug 1338889 - Part 2: Support DOMString as Argument 3 of Document.createElementNS. r=bz

fix for Document.createElementNS, beta52+

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9304343071d4
https://hg.mozilla.org/releases/mozilla-aurora/rev/8103314b2cd4

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe7d82eec131
https://hg.mozilla.org/releases/mozilla-beta/rev/372604365ac4

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/fe7d82eec131
https://hg.mozilla.org/releases/mozilla-esr52/rev/372604365ac4