Closed
Bug 1338890
Opened 9 years ago
Closed 9 years ago
PuppetWidget::NeedsPaint() should not use Preferences::GetBool but AddBoolVarCache
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: smaug, Unassigned)
References
Details
Attachments
(1 file)
|
1.69 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
PuppetWidget::NeedsPaint() is called in rather hot code paths, so it shouldn't use GetBool but AddBoolVarCache.
|
Reporter | |
Updated•9 years ago
|
Flags: needinfo?(gwright)
|
||
Comment 1•9 years ago
|
||
Attachment #8838659 -
Flags: review?(bugs)
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8838659 -
Flags: review?(bugs) → review+
Pushed by gwright@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d821ad73279
Cache our tab behaviour instead of requesting it each time on a hot path r=smaug
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
|
||
Updated•9 years ago
|
Flags: needinfo?(gw)
You need to log in
before you can comment on or make changes to this bug.
Description
•