1338899 - Use getter/setter for Gecko-side tab.parentId

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Henning [:JanH]]

Should be more fool-proof than having to remember to call setParentId.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1338899 - Part 0 - Fix test title.

Fix copy & paste error made when creating the new test file.

Review commit: https://reviewboard.mozilla.org/r/111900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111900/

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1338899 - Part 1 - Use getter/setter for accessing/modifying a tab's parent ID in Gecko.

This should be more foolproof than having to remember to use the dedicated setParentId() function when writing to that variable from outside of the tab constructor.

Review commit: https://reviewboard.mozilla.org/r/111902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111902/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8836474 [details]
Bug 1338899 - Part 0 - Fix test title.

https://reviewboard.mozilla.org/r/111900/#review113272

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8836475 [details]
Bug 1338899 - Part 1 - Use getter/setter for accessing/modifying a tab's parent ID in Gecko.

https://reviewboard.mozilla.org/r/111902/#review113274

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8b186815241
Part 0 - Fix test title. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/6b89d6cdb5f6
Part 1 - Use getter/setter for accessing/modifying a tab's parent ID in Gecko. r=sebastian

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e8b186815241
https://hg.mozilla.org/mozilla-central/rev/6b89d6cdb5f6