1338928 - Const data tables should go in a read-only data section (intl/)

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[(Away)]

Attachment: Add constexpr

Please see bug 1334254 comment 0 for background.

These changes move 4.5k of tables from the .data section to the read-only .rdata section.

Comment 1

[(Away)]

I forgot to mention: the change in nsUNIXCharset.cpp is, of course, unnecessary for the Visual Studio workaround. But I added it anyway for consistency.

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8836520 [details] [diff] [review]
Add constexpr

Review of attachment 8836520 [details] [diff] [review]:
-----------------------------------------------------------------

Are you sure this change has no side-effects on other compilers? But 1255655 added the const for this very reason.

Comment 3

[Masatoshi Kimura [:emk]]

> But 1255655
Bug 1255655

Comment 4

[(Away)]

Prior to bug 1255655, the arrays were not const at all, so that bug's change makes sense. 

Constexpr is like const but even stronger (if you try to say "const constexpr", the compiler complains about "duplicate const") so this shouldn't disturb existing const data.

Comment 5

[Masatoshi Kimura [:emk]]

Thanks for explaining.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a93ad0b96cc
Add constexpr to static data under intl/ for better codegen on Windows. r=emk

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a93ad0b96cc