1338975 - Crash in java.lang.IllegalStateException: at android.os.Parcel.readException(Parcel.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-e57b80e3-329e-4727-a8f9-711b12170212.
=============================================================

This is the #1 topcrash in Aurora 20170210084116, with 25 occurrences. It's also showing up a bit on Nightly. There's a bit of variety in the Java stack traces, though they all seem to go through ICodec.java.

Looks like it first started happening in January.

Jim, any ideas?

Comment 1

[John Lin [:jhlin][:jolin]]

Looks like some exceptions were not caught in remote decoder and leaked to local proxy.

Comment 2

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1338975 - Don't leak MediaCodec exceptions to CodecProxy.

Review commit: https://reviewboard.mozilla.org/r/112544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112544/

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8837404 [details]
Bug 1338975 - Don't leak MediaCodec exceptions to CodecProxy.

https://reviewboard.mozilla.org/r/112544/#review114298

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/959ce2584a80
Don't leak MediaCodec exceptions to CodecProxy. r=jchen

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/959ce2584a80

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this when you get a chance.

Comment 7

[John Lin [:jhlin][:jolin]]

Comment on attachment 8837404 [details]
Bug 1338975 - Don't leak MediaCodec exceptions to CodecProxy.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1338975
[User impact if declined]: browser crash when playing video/audio.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: it catches more exceptions from codec 
[String changes made/needed]: none

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8837404 [details]
Bug 1338975 - Don't leak MediaCodec exceptions to CodecProxy.

Fix a crash. Aurora53+.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c4dda37794c1