1339076 - Make sure the right hooks are running on mozilla-esr52

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

I just tried pushing to esr52 and hit the webidl hook. I'm guessing that esr52 needs some tweaking in what hooks are running (as I'm pretty sure that one shouldn't be). Probably easiest to just steal esr45's config?

I believe this is in your ballpark, fubar?

Comment 1

[Kendall Libby [:fubar] (he/him)]

They have the same config as far as hooks are concerned:

[hooks]
changegroup.push_printurls = python:mozhghooks.push_printurls.hook
prepushkey.prevent_bookmarks = python:mozhghooks.prevent_bookmarks.hook
pretxnchangegroup.a_treeclosure = python:mozhghooks.treeclosure.hook
pretxnchangegroup.b_singlehead = python:mozhghooks.single_head_per_branch.hook
pretxnchangegroup.c_nouuidchanges = python:mozhghooks.prevent_uuid_changes.hook
pretxnchangegroup.e_idl_no_uuid = python:mozhghooks.prevent_idl_change_without_uuid_bump.hook
pretxnchangegroup.f_prevent_vendored = python:mozhghooks.prevent_vendored_changes.hook

And prevent_webidl_changes isn't in the system hgrc either.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I'm sorry, I misspoke in #c0. It's actually the prevent_idl_change_without_uuid_bump hook I was hitting.

(In reply to Kendall Libby [:fubar] from comment #1)
> pretxnchangegroup.c_nouuidchanges =
> python:mozhghooks.prevent_uuid_changes.hook

This hook hasn't been needed since bug 1159737 removed support for binary extensions. Not sure why mozilla-beta was the only repo to ever have the hook removed as this is a change that rode the 41 train. I see no reason for release/esr45/esr52 to have it enabled at this point. Not that I can find the bug where it got removed from Beta either.

> pretxnchangegroup.e_idl_no_uuid =
> python:mozhghooks.prevent_idl_change_without_uuid_bump.hook

Not needed for Gecko 47+ per https://groups.google.com/forum/#!topic/mozilla.dev.platform/HE1_qZhPj1I.

Comment 3

[Kendall Libby [:fubar] (he/him)]

Removed the prevent_uuid_changes hook from mozilla-esr52, esr45, and mozilla-release. Removed the prevent_idl_change_without_uuid_bump from mozilla-esr52; if you'd like it removed from others, please list them out (so that it's easier to search for them down the road ;-)).

Comment 4

[Ryan VanderMeulen [:RyanVM]]

(In reply to Kendall Libby [:fubar] from comment #3)
> if you'd like it removed from others, please list them out
> (so that it's easier to search for them down the road ;-)).

Thanks!

Let's remove prevent_idl_change_without_uuid_bump from anything that isn't ESR45 - mozilla-central, mozilla-aurora, mozilla-beta, and mozilla-release.

Comment 5

[Kendall Libby [:fubar] (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> Let's remove prevent_idl_change_without_uuid_bump from anything that isn't
> ESR45 - mozilla-central, mozilla-aurora, mozilla-beta, and mozilla-release.

Ok, of those it was only on -release and I've commented it out.