Closed Bug 1339087 Opened 5 years ago Closed 5 years ago

[bg] Not localized single locale build

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

53 Branch
defect
Not set
normal

Tracking

(firefox51 unaffected, firefox52 unaffected, firefox53 fixed, firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: stoyan, Assigned: aki)

Details

Attachments

(3 files, 1 obsolete file)

Single locale build from yesterday (today too, possible few days back) is not localized. It is in English.
Summary: Not localized single locale build → [bg] Not localized single locale build
I couldn't find anything in the logs. Stoyan, to be precise, is this on nightly or aurora?
Downloaded https://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-aurora-android-api-15-l10n/fennec-53.0a2.bg.android-arm.apk.

omni.ja has English strings in the bg files in omni.ja. resources.arsc has all kinds of languages in it. apktool shows that it has

res/values-af
res/values-am
res/values-ar
res/values-az-rAZ
res/values-bg
res/values-bn-rBD
res/values-ca
res/values-cs
res/values-da
res/values-de
res/values-el
res/values-en-rAU
res/values-en-rGB
res/values-en-rIN
res/values-es
res/values-es-rUS
res/values-et-rEE
res/values-eu-rES
res/values-fa
res/values-fi
res/values-fr
res/values-fr-rCA
res/values-gl-rES
res/values-gu-rIN
res/values-hi
res/values-hr
res/values-hu
res/values-hy-rAM
res/values-in
res/values-is-rIS
res/values-it
res/values-iw
res/values-ja
res/values-ka-rGE
res/values-kk-rKZ
res/values-km-rKH
res/values-kn-rIN
res/values-ko
res/values-ky-rKG
res/values-lo-rLA
res/values-lt
res/values-lv
res/values-mk-rMK
res/values-ml-rIN
res/values-mn-rMN
res/values-mr-rIN
res/values-ms-rMY
res/values-my-rMM
res/values-nb
res/values-ne-rNP
res/values-nl
res/values-pa-rIN
res/values-pl
res/values-pt
res/values-pt-rBR
res/values-pt-rPT
res/values-ro
res/values-ru
res/values-si-rLK
res/values-sk
res/values-sl
res/values-sq-rAL
res/values-sr
res/values-sv
res/values-sw
res/values-ta-rIN
res/values-te-rIN
res/values-th
res/values-tl
res/values-tr
res/values-uk
res/values-ur-rPK
res/values-uz-rUZ
res/values-vi
res/values-zh-rCN
res/values-zh-rHK
res/values-zh-rTW
res/values-zu

The strings.xml inside those look like they're properly localized.

res/values/strings.xml is English, though in a single-locale repack I think I'd expect it to be localized?
10:47 <Pike> but I think I found the culprit
10:48 <Pike> '--l10n-base', '/home/worker/workspace/build/mozilla-aurora', 'bg']  for compare-locales
10:48 <Pike> and --l10n-base=/home/worker/workspace/build/src/bg for the installers-bg step
10:48 <Pike> basically, the l10n checkout isn't where the build expects it

I took a look at the multilocale log, and it appears to be using the correct l10n-base for both compare-locales and packaging.
I think we need to address the l10n-base for installers-% to be /home/worker/workspace/build/mozilla-aurora/LOCALE; I'm currently trying to figure out how to do so in the build system.
I think this is a mozconfig issue:
[task 2017-02-13T09:30:23.951907Z] 09:30:23     INFO -  ac_add_options --with-l10n-base=..

I'm not sure if it's easier to adjust the mozconfig, or adjust the mozharness config.
The linux desktop single-locale repacks on aurora seem to all use x-test and are missing mergedirs? https://public-artifacts.taskcluster.net/OMN5kW4nQpiRBZmcon-6ew/0/public/logs/certified.log

I believe the fix for android single-locale is to adjust the mozconfig to specify ../../mozilla-aurora as the l10n base.  To avoid hitting this bug next merge day, we'll need to adjust the merge day tools in mozilla-central.
We already uplifted into aurora, so these are changes we'll need in aurora to fix the android repack issues here, and for beta/release merge days.  The central patch is in mozreview.
Assignee: nobody → aki
Attachment #8836875 - Flags: review?(rail)
Attachment #8836875 - Flags: review?(rail) → review+
Comment on attachment 8836876 [details]
bug 1339087 - adjust android merge day configs for tc builds.

https://reviewboard.mozilla.org/r/112182/#review113452
Attachment #8836876 - Flags: review?(rail) → review+
Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b243c8dac97
adjust android merge day configs for tc builds. r=rail
Comment on attachment 8836875 [details] [diff] [review]
mozilla-aurora-android.diff

Approval Request Comment
[Feature/Bug causing the regression]:  Android on Taskcluster
[User impact if declined]: Android single locale builds on fx53 will not be localized
[Is this code covered by automated tests?]: That would be nice, but not as far as I know, yet
[Has the fix been verified in Nightly?]: This patch is aurora-specific, so no
[Needs manual test from QE? If yes, steps to reproduce]: Sure, or verification from the reporter.  STR: install a single locale android mozilla-aurora build containing this fix, and verify it is localized.  (Without the fix, it will not be localized)
[List of other uplifts needed for the feature/fix]: Hopefully this will work, and will cover the aurora->beta and beta->release merge days
[Is the change risky?]: I don't think so.
[Why is the change risky/not risky?]: Either this fixes it, or we continue having broken android single locale repacks.
[String changes made/needed]: N/a
Attachment #8836875 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/7b243c8dac97
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
[Tracking Requested - why for this release]:
This fix is needed to get Android l10n repacks working for Fx53.  A patch already landed on m-c so Fx54+ should work, but we still need approval for the aurora patch.
Comment on attachment 8836875 [details] [diff] [review]
mozilla-aurora-android.diff

Pushed with a=release
Attachment #8836875 - Flags: approval-mozilla-aurora?
res/values/strings.xml now looks mostly localized.  :stoyan, does the latest aurora bg apk look good to you?
Flags: needinfo?(stoyan)
(In reply to Aki Sasaki [:aki] from comment #14)
> res/values/strings.xml now looks mostly localized.  :stoyan, does the latest
> aurora bg apk look good to you?

Yes, Aki the build is localized. Thank you all.
Flags: needinfo?(stoyan)
Comment on attachment 8844187 [details]
No bug - Tagging mozilla-central 517c553ad64746c479456653ce11b04ab8e4977f with FIREFOX_AURORA_54_BASE a=release DONTBUILD CLOSED TREE

This review shouldn't have been published
Attachment #8844187 - Attachment is obsolete: true
Comment on attachment 8844188 [details]
Bug 1339087 - Merge day: fix up l10n file location  a=release

https://reviewboard.mozilla.org/r/117724/#review119406

r+
Attachment #8844188 - Flags: review?(jlund) → review+
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/6583496f169c
Merge day: fix up l10n file location r=jlund a=release
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 54 → mozilla54
You need to log in before you can comment on or make changes to this bug.