1339119 - OSPreferences::GetSystemLocale incorrectly returns 'und' on macOS

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jonathan Kew [:jfkthame]]

The Mac implementation of ReadSystemLocales has a bug, such that it ignores the locale read from the system and passes an empty string to CanonicalizeLanguageTag, which ICU then canonicalizes to "und". Not helpful.

The fix is trivial; we just failed to set the length of `buffer` properly.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Actually use the locale from macOS instead of throwing it away in OSPreferences::ReadSystemLocales

Oops, obviously I overlooked this when we were doing bug 1333184. Good thing nobody is relying on it yet. :)

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Great catch! I am building FX on Windows and Mac today to test the new APIs. :)

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c2044bedc9e9ba7e892eea4ec47a2a8bfce36ba
Bug 1339119 - Actually use the locale from macOS instead of throwing it away in OSPreferences::ReadSystemLocales. r=gandalf

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2c2044bedc9e