layout panel : do not mention multiple overlays in grid overlay picker

RESOLVED FIXED in Firefox 54

Status

()

Firefox
Developer Tools: Inspector
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

The layout panel allows to select which overlay to display.
Ultimately this will allow to select several overlays hence the title "Overlay Multiple Grids" and the use of checkbox.

In the mvp however, only one overlay can be picked. Title should be changed to "Overlay Grid" or "Select Overlay Grid".

Also the checkboxes could be switched to radio buttons in the meantime.
(Assignee)

Updated

9 months ago
Version: 52 Branch → unspecified
Comment hidden (mozreview-request)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8837602 [details]
Bug 1339121 - update header of grid overlay section;

https://reviewboard.mozilla.org/r/112716/#review114216
Attachment #8837602 - Flags: review?(gl) → review+

Comment 3

9 months ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16b0fffa1283
update header of grid overlay section;r=gl

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/16b0fffa1283
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
(In reply to Julian Descottes [:jdescottes] from comment #0)
> The layout panel allows to select which overlay to display.
> Ultimately this will allow to select several overlays hence the title
> "Overlay Multiple Grids" and the use of checkbox.

Does it mean that layout.overlayMultipleGrids is not used, and might not be in the future?
Right now layout.overlayMultipleGrids is not used. But it will be used as soon as we support displaying several grids at the same time.

When this happens, the new string introduced here (layout.overlayGrid) will no longer be used and will be removed.
We thought it made more sense to keep the existing layout.overlayMultipleGrids in the properties file, since it will be used in the future.
(In reply to Julian Descottes [:jdescottes] from comment #6)
> When this happens, the new string introduced here (layout.overlayGrid) will
> no longer be used and will be removed.
> We thought it made more sense to keep the existing
> layout.overlayMultipleGrids in the properties file, since it will be used in
> the future.

It makes absolutely sense. Thanks for confirming.
You need to log in before you can comment on or make changes to this bug.