1339129 - Remove access to http-only cookies from the child process

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[(no longer active)]

CookieServiceChild::GetCookieStringFromHttp() is currently dead code in the content process since it's only used in nsHttpChannel in the parent side.  We should just make it impossible for the child process to ever get access to the HTTP-only cookies.

Comment 1

[(no longer active)]

Attachment: Remove access to HTTP-only cookies from the child process

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c27179ee59e9
Remove access to HTTP-only cookies from the child process; r=jdm

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing xpcshell tests netwerk/cookie/test/unit_ipc/test_ipc_parser_0001.js and test_ipc_parser_0019.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a0bdc9f6c1d118c3274157dc6359d50b7aca4e3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c27179ee59e9eb226224ec11b907ccce6289fc0c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=76919530&repo=mozilla-inbound

[task 2017-02-13T20:05:24.667472Z] 20:05:24     INFO -  TEST-START | netwerk/cookie/test/unit_ipc/test_ipc_parser_0001.js
[task 2017-02-13T20:05:26.660619Z] 20:05:26  WARNING -  TEST-UNEXPECTED-FAIL | netwerk/cookie/test/unit_ipc/test_ipc_parser_0001.js | xpcshell return code: 0
[task 2017-02-13T20:05:26.661018Z] 20:05:26     INFO -  TEST-INFO took 1994ms
[task 2017-02-13T20:05:26.663846Z] 20:05:26     INFO -  >>>>>>>
[task 2017-02-13T20:05:26.665868Z] 20:05:26     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2017-02-13T20:05:26.671230Z] 20:05:26     INFO -  PROCESS | 10402 | JavaScript strict warning: /home/worker/workspace/build/tests/xpcshell/head.js, line 1251: ReferenceError: assignment to undeclared variable _XPCSHELL_PROCESS
[task 2017-02-13T20:05:26.673210Z] 20:05:26     INFO -  (xpcshell/head.js) | test run in child pending (2)
[task 2017-02-13T20:05:26.675065Z] 20:05:26     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2017-02-13T20:05:26.676975Z] 20:05:26     INFO -  running event loop
[task 2017-02-13T20:05:26.679008Z] 20:05:26     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: assignment to undeclared variable _XPCSHELL_PROCESS" {file: "/home/worker/workspace/build/tests/xpcshell/head.js" line: 1251}]"
[task 2017-02-13T20:05:26.681022Z] 20:05:26     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2017-02-13T20:05:26.682917Z] 20:05:26     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2017-02-13T20:05:26.684715Z] 20:05:26     INFO -  CHILD-TEST-STARTED
[task 2017-02-13T20:05:26.686712Z] 20:05:26     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2017-02-13T20:05:26.688904Z] 20:05:26     INFO -  NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsICookieService.setCookieStringFromHttp]
[task 2017-02-13T20:05:26.691504Z] 20:05:26     INFO -  run_test@/home/worker/workspace/build/tests/xpcshell/tests/netwerk/cookie/test/unit/test_parser_0001.js:23:3
[task 2017-02-13T20:05:26.695193Z] 20:05:26     INFO -  _execute_test@/home/worker/workspace/build/tests/xpcshell/head.js:536:7
[task 2017-02-13T20:05:26.697083Z] 20:05:26     INFO -  @typein:0:158
[task 2017-02-13T20:05:26.698993Z] 20:05:26     INFO -  CHILD-TEST-COMPLETED
[task 2017-02-13T20:05:26.700804Z] 20:05:26     INFO -  (xpcshell/head.js) | test finished (1)
[task 2017-02-13T20:05:26.703318Z] 20:05:26     INFO -  exiting test
[task 2017-02-13T20:05:26.705098Z] 20:05:26     INFO -  <<<<<<<

Comment 5

[(no longer active)]

These tests are just testing the code being removed, so they can be removed as well, I think.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d7d9d00b98f
Remove access to HTTP-only cookies from the child process; r=jdm

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0d7d9d00b98f