1339213 - Inline IsRestrictOpenerAccessForFPI

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

IsRestrictOpenerAccessForFPI is called in very hot code paths so better to inline it.

Patch coming.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

privacy.firstparty.isolate.restrict_opener_access part is untested since we don't seem to have tests for it.

Comment 2

[Tim Huang[:timhuang]]

Comment on attachment 8836884 [details] [diff] [review]
v1

Review of attachment 8836884 [details] [diff] [review]:
-----------------------------------------------------------------

::: caps/BasePrincipal.h
@@ +100,5 @@
>    // flags. Once all other flags are removed, this can be removed too.
>    void SyncAttributesWithPrivateBrowsing(bool aInPrivateBrowsing);
>  
>    // check if "privacy.firstparty.isolate" is enabled.
> +  static bool IsFirstPartyEnabled()

I believe that the compiler will optimize for us to make this an inline function. However, I think we should use 'static inline' here to tell the compiler explicitly.

@@ +108,5 @@
>  
>    // check if the access of window.opener across different FPDs is restricted.
>    // We only restrict the access of window.opener when first party isolation
>    // is enabled and "privacy.firstparty.isolate.restrict_opener_access" is on.
> +  static bool IsRestrictOpenerAccessForFPI()

ditto

Comment 3

[Tim Huang[:timhuang]]

Bug 1339336 has been filed for the test case. Thanks for bringing this up, smaug.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I guess inline does kind of self document the performance sensitiveness, I could add them.
Usually we don't use them with this kind of small methods, but just expect compiler to inline.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: inline_fpi.diff

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29784b27d405
Inline IsRestrictOpenerAccessForFPI, r=tihuang

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/29784b27d405