Closed Bug 1339226 Opened 9 years ago Closed 7 years ago

Update download buttons for Windows XP/Vista users once Firefox 52 ESR reaches EOL

Categories

(www.mozilla.org :: Pages & Content, defect)

Product:
www.mozilla.org
Component:
Pages & Content
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52- affected)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox52 - affected

People

(Reporter: kohei, Assigned: kohei)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/bedrock/pull/6044
44 bytes, text/x-github-pull-request
Details | Review
Windows XP/Vista EOL is approaching, and those users will soon be migrated to Firefox 52 ESR coming March 7 (only in 3 weeks!) https://blog.mozilla.org/futurereleases/2016/12/23/firefox-support-for-xp-and-vista/ We need to update the download buttons accordingly. Some ideas: * Release channel: * Continue showing the XP/Vista download button for convenience sake * Make sure the button offers Firefox 52 ESR * Other channels: * Remove the XP/Vista download button * Show the unsupported system copy "Your system may not meet the requirements"
This sounds fine to me. We could maybe redirect users on other channels who visit the download page to the 52 ESR page. Though, if we give a message about that separate from the usual "unsupported" message, it would need to be localized.
status-firefox52: --- → affected
tracking-firefox52: --- → blocking
Kohei, these are great suggestions. Is this something you can help with? Jon, what is the next step if we'd like to consider implementing some of these suggestions? I am most interested in redirecting the /new page's "Free Download" to ESR 52 for XP/Vista users. We plan to migrate users who somehow installed non-ESR Firefox 52 on XP/Vista to ESR 52, but users might not receive that update for a day or two. (In reply to Kohei Yoshino [:kohei] from comment #0) > We need to update the download buttons accordingly. Some ideas: > > * Release channel: > * Continue showing the XP/Vista download button for convenience sake > * Make sure the button offers Firefox 52 ESR When you say "XP/Vista download button", are you referring to the "Free Download" button on https://www.mozilla.org/firefox/new/ or some other button? > * Other channels: > * Remove the XP/Vista download button > * Show the unsupported system copy "Your system may not meet the > requirements" Where is the unsupported message shown? On the https://www.mozilla.org/firefox/channel/ page?
Flags: needinfo?(kohei.yoshino)
Flags: needinfo?(jon)
(In reply to Chris Peterson [:cpeterson] from comment #2) > Kohei, these are great suggestions. Is this something you can help with? I can help if needed :) > When you say "XP/Vista download button", are you referring to the "Free > Download" button on https://www.mozilla.org/firefox/new/ Yes, I meant it. > Where is the unsupported message shown? On the > https://www.mozilla.org/firefox/channel/ page? Yes. We are already showing the unsupported message to those on other older platforms.
Flags: needinfo?(kohei.yoshino)
(In reply to Chris Peterson [:cpeterson] from comment #2) > Jon, what is the next step if we'd like to consider implementing some of > these suggestions? I am most interested in redirecting the /new page's "Free > Download" to ESR 52 for XP/Vista users. We plan to migrate users who somehow > installed non-ESR Firefox 52 on XP/Vista to ESR 52, but users might not > receive that update for a day or two. We currently have non-trivial special casing in place for serving up downloads to XP & Vista users. A solid set of requirements would need to be set prior to kicking off research into dev time. Any place you see a single download button on mozilla.org, you are seeing the results of JS and CSS manipulation. We render a download button for each platform based on the release channel specified. We use JS to detect the user's platform, which in turn applies a CSS class to the <body>, which takes care of showing the button most appropriate to the user's detected platform. All other buttons are hidden. Loading the /new page with JS disabled is the best way to see what's really being rendered by the template. This behavior is currently consistent across release channels. We have a special platform defined for XP & Vista users (winsha1), which uses a different base URL to serve up a SHA-1 capable download. It sounds like what we need is: 1. a hard-coded full URL to the 52 ESR download to be used for the winsha1 platform on all release channel download buttons 2. for XP/Vista users looking at non-release channel buttons, code to remove the XP/Vista button and to display the "unsupported platform" message Does that sound right? > > (In reply to Kohei Yoshino [:kohei] from comment #0) > > We need to update the download buttons accordingly. Some ideas: > > > > * Release channel: > > * Continue showing the XP/Vista download button for convenience sake > > * Make sure the button offers Firefox 52 ESR > > When you say "XP/Vista download button", are you referring to the "Free > Download" button on https://www.mozilla.org/firefox/new/ or some other > button? When on XP or Vista, the "Free Download" button points to the special XP/Vista download URL. When on *any* browser without JS (or when JS fails to execute), a list of download buttons is shown, one being "Windows (XP/Vista)", which points to the same special XP/Vista download URL. Maybe we should have a meeting to discuss? I'm currently on loan to the MDN team, and am not sure what the current priorities/workload are on mozilla.org. (Though this sounds pretty important.) I'm cc'ing Eric Renaud to make sure he's aware and can consider where the work can fit with other tasks.
Flags: needinfo?(jon)
Alex - setting needinfo for you as the request that you review the bug here and provide your assessment on LOE and/or pose any further questions. Given the timing (Fx 52, March 7), there is or will soon be an element of urgency.
Flags: needinfo?(agibson)
Peter, do we care that new downloads of Firefox 52 for XP/Vista will get regular Firefox 52 until they are migrated to ESR 52 at their next update check, a day or two later? Rail already plans to handle this migration case on the update server side. The only problem with XP/Vista users running regular Firefox 52 for a couple days before be migrated to ESR 52 is that Silverlight and some NPAPI plugins won't work during that period. The primary broken use case will be Netflix for XP users. Firefox doesn't support H.264 HTML5 video on XP, so Netflix and other streaming services rely on Silverlight. Can you query how many new downloads we saw of, say, Firefox 51 by XP/Vista users? That would give us a rough idea of how many people might lost Silverlight for a few days. Given the amount of frontend work described in comment 4 to fix the button link for a temporary problem, I am strongly inclined to WONTFIX this bug.
Flags: needinfo?(pdolanjski)
> Given the amount of frontend work described in comment 4 to fix the button link for a temporary problem, I am strongly inclined to WONTFIX this bug. We already have UA/Platform detection for XP/Vista users in the download button app for pointing those users to the sha-1 instance of bouncer. If we wanted to, we could use that same logic to hard-code those links to point to ESR 52 explicitly. The more fiddly part would probably be to show the "not supported" message only for buttons that link to pre-release versions of Firefox. Not quite 100% how I'd handle that yet, but I'm sure we could work out a way that's not too ugly. I'll wait for Peter's reply before starting any work - but I think we can do this if we think it's warranted.
Flags: needinfo?(agibson)
Another possible solution would be to handle the redirect in Bouncer itself, as opposed to bedrock. This could help mitigate issues like needing to update the hard-coded link in bedrock should ESR 52 need any minor point releases. I couldn't comment on the LOE that would be needed to do this in Bouncer, but I do believe they also have logic to detect XP/Vista already.
(In reply to Alex Gibson [:agibson] from comment #8) > Another possible solution would be to handle the redirect in Bouncer itself, > as opposed to bedrock. Yes! Reading my old meeting notes, I see that we already plan to handle this case in Bouncer itself. Thus, I think we can WONTFIX this bug. @ Rail, before I WONTFIX this bug, I just wanted to confirm we can do this all in Bouncer. My meeting notes say: > When XP/Vista users try to download Release 52, Bouncer will serve them the ESR 52 installer. > Bouncer already special-cases XP/Vista users to serve them the SHA-1 repack installer. https://docs.google.com/document/d/1_DyTaS0uqv8uGcAcgKTwc1s1IvAS1ZoFynd2dZnfbJg/edit#heading=h.q6tfhiojzcj0
Flags: needinfo?(pdolanjski) → needinfo?(rail)
I filed bug 1340263 so simplify (\o/) bouncer logic and redirect all downloads coming from XP/Vista UAs to ESR based SHA1 repacks. They are not ready yet though (ETA March 7). This should simplify Bedrock side changes as well, but I'm not sure if you want to WONTFIX this bug though (there may be some clean up?).
Flags: needinfo?(rail)
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #10) > I filed bug 1340263 so simplify (\o/) bouncer logic and redirect all > downloads coming from XP/Vista UAs to ESR based SHA1 repacks. They are not > ready yet though (ETA March 7). > > This should simplify Bedrock side changes as well, but I'm not sure if you > want to WONTFIX this bug though (there may be some clean up?). OK, good to know this is already being handled, thanks! I believe we'll need to keep our sha-1 button logic around at least until the end of support for ESR 52, so we can close this bug as WONTIFX.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Looks like the request is being handled in comment 10 with specified mechanism. If there is any dependency as to ESR52, we can use tracking-firefox-esr52. Liz, I guess blocking flag is no longer needed here.
Flags: needinfo?(lhenry)
I think we still have to remove the Nightly/DevEdition/Beta download buttons for XP/Vista users. It may not be a blocker though.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
(In reply to Kohei Yoshino [:kohei] from comment #13) > I think we still have to remove the Nightly/DevEdition/Beta download buttons > for XP/Vista users. It may not be a blocker though. We discussed this briefly and don't think it's really a priority given the small audience and LOE required to hide those buttons. Unless anyone disagrees, I think this can still probably be a WONTFIX.
It also looks like bug 1340263 is redirecting all products to ESR 52 for XP/Vist users. Based on this, I'm going to close this bug again. If I'm misinterpreting something please reopen if we do still want to do something for pre-release users. Also fwiw, Nightly download buttons have never worked for XP/Vista users since it uses a sha-256 cert.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → WONTFIX
tracking-firefox52: blocking → -
Flags: needinfo?(lhenry)
Okay, let's do this once Windows XP/Vista officially reaches EOL.
Sorry for being late! but I’ve been asked by :cpeterson to work on this. There are a couple of things to do: 1. https://www.mozilla.org/firefox/new/ * Show a warning at the top of the page (instead of the existing Firefox status message) * Prototype: https://screenshots.firefox.com/OwUWUg7mbLdxT58c/localhost 2. Download buttons on https://www.mozilla.org/firefox/ and other pages * Show a warning above the download CTA: “Mozilla no longer provides security updates for Firefox on Windows XP or Vista, but you can still download the final Windows 32-bit version below.” * Continue showing the download button to XP/Vista users so they can still get 52 ESR 3. https://www.mozilla.org/firefox/all/ * Show the same warning above the download links * Prototype: https://screenshots.firefox.com/oRxMliES4OCh4E73/localhost 4. Pre-release download buttons on https://www.mozilla.org/firefox/channel/desktop/ and https://www.mozilla.org/firefox/developer/ * (I haven’t heard anything on this, but given that these are not ESR downloads) Hide the download button behind the regular unsupported message: “Your system doesn’t meet the requirements to run Firefox.” PR coming shortly.
Status: RESOLVED → REOPENED
Component: General → Pages & Content
Resolution: WONTFIX → ---
See Also: → 1463436
Assignee: nobody → kohei.yoshino
Status: REOPENED → ASSIGNED
Summary: Update download buttons for Windows XP/Vista (almost) EOL → Update download buttons for Windows XP/Vista users once Firefox 52 ESR reaches EOL
Chris, there are prototype links above. Your emails didn’t mention the warning at the top of the page so I’ve just put “You’re using an insecure, outdated operating system no longer supported by Firefox.” Both warnings link to https://support.mozilla.org/kb/end-support-windows-xp-and-vista. Is that okay for you?
Flags: needinfo?(cpeterson)
(In reply to Kohei Yoshino [:kohei] from comment #18) > Chris, there are prototype links above. Your emails didn’t mention the > warning at the top of the page so I’ve just put “You’re using an insecure, > outdated operating system no longer supported by Firefox.” Both warnings > link to https://support.mozilla.org/kb/end-support-windows-xp-and-vista. Is > that okay for you? Your screenshots look good! I hadn't considered that users might not know they are running an unsupported operating system and thus the "Windows XP or Vista" warning applies to them. The "You're using an insecure, outdated operating system no longer supported by Firefox." warning will help. > 4. Pre-release download buttons on > https://www.mozilla.org/firefox/channel/desktop/ and > https://www.mozilla.org/firefox/developer/ > > * (I haven’t heard anything on this, but given that these are not ESR > downloads) Hide the download button behind the regular unsupported message: > “Your system doesn’t meet the requirements to run Firefox.” That's a good point. None of those Firefox channel builds will even run on Windows XP or Vista.
Flags: needinfo?(cpeterson)
Thanks for the confirmation! Let’s proceed with these messages.
This download button is not mentioned above and probably needs attention: On https://www.mozilla.org/en-US/firefox/organizations/ there is a download button with title "Get Firefox 52 ESR" linking to https://www.mozilla.org/en-US/firefox/organizations/all/#legacy which in turn only displays downloads for Firefox 60 ESR. Maybe remove the "Get Firefox 52 ESR" button, or link it to the info page (https://support.mozilla.org/kb/end-support-windows-xp-and-vista)?
Commit pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/333d3df02ad697f1694a88553119f98931519557 Fix Bug 1339226 - Update download buttons for Windows XP/Vista users once Firefox 52 ESR reaches EOL
Status: ASSIGNED → RESOLVED
Closed: 9 years ago → 7 years ago
Resolution: --- → FIXED
How long does it take before the new changes are live on mozilla.org? I spoofed a Windows XP User-Agent string by setting pref "general.useragent.override" to "Mozilla/5.0 (Windows NT 5.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0". Neither https://www.mozilla.org/en-US/firefox/ nor https://www.mozilla.org/en-US/firefox/all/ show the "Mozilla no longer provides security updates for Firefox on Windows XP" warning message. Clicking the download links, however, does correctly download the "Firefox Setup 52.9.0esr.exe" instead of the latest Firefox 62 version, so I know that the Bouncer sees my Windows XP User-Agent string.
Production pushes are manual. It'll go out with the next one which should be later today or tomorrow. If we need it ASAP please let us know.
(In reply to Paul [:pmac] McLanahan ⏰ET needinfo? me from comment #25) > Production pushes are manual. It'll go out with the next one which should be > later today or tomorrow. If we need it ASAP please let us know. No hurry! :) I just wanted to know when I can test the new page. I'll check back later this week.
Thanks again kohei :) And I'll do my best to post here when the prod deployment is done.
Changes went to prod about 3 hours ago. Thanks all!
It works! Kohei, thank you again for designing these new security warnings. :D As expected, when spoofing an XP or Vista UA, https://www.mozilla.org/en-US/firefox/new/ warns: > You’re using an insecure, outdated operating system no longer supported by Firefox. And https://www.mozilla.org/en-US/firefox/all/ warns: > Mozilla no longer provides security updates for Firefox on Windows XP or Vista, but you can still download the final Windows 32-bit version.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: