Upstream webrtc code doesn't add padding packets to retransmission history (Issue 7143)

RESOLVED FIXED in Firefox 54

Status

()

Core
WebRTC: Networking
P1
normal
Rank:
15
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

45 Branch
mozilla54
Points:
---

Firefox Tracking Flags

(firefox-esr45 wontfix, firefox51 wontfix, firefox52 affected, firefox-esr52 affected, firefox53 affected, firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Upstream code in webrtc.org branch 49 and 57 (and 43) don't add padding packets (RTPSender::SendPadData()) to the rtp packet history.  If one of the padding packets is lost, it can't be retransmitted, and the other side's jitter buffer will still until the next keyframe, or until it times out waiting for a retransmit and requests a keyframe.  This causes freezes and lower video quality.

Webrtc.org issue 7143: https://bugs.chromium.org/p/webrtc/issues/detail?id=7143
(Assignee)

Updated

a year ago
Rank: 15
(Assignee)

Comment 1

a year ago
Created attachment 8836923 [details] [diff] [review]
Add rtp 'padding' packets into rtp history for handling NACKs

this also causes the simulcast tests to be flaky under rr, for example
Attachment #8836923 - Flags: review?(na-g)

Updated

a year ago
Attachment #8836923 - Flags: review?(na-g) → review+

Comment 2

a year ago
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6bdf4cf8348
Add rtp 'padding' packets into rtp history for handling NACKs r=ng

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b6bdf4cf8348
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
See Also: → bug 1337810
See Also: bug 1337810
You need to log in before you can comment on or make changes to this bug.