1339356 - stylo: Assertion failure: aFrame || (aHint & nsChangeHint_ReconstructFrame) (must have frame), at nsStyleChangeList.cpp:20

Status: RESOLVED WORKSFORME

(Core :: Layout, defect, P2)

Description

[Carsten Book [:Tomcat]]

Assertion failure: aFrame || (aHint & nsChangeHint_ReconstructFrame) (must have frame), at /home/worker/workspace/build/src/layout/base/nsStyleChangeList.cpp:20

found via bughunter and reproduced on latest stylo debug build

Steps to reproduce:
-> Load http://www.androidauthority.com/best-bluetooth-gaming-controllers-403184/
--> Assertion failure 

gdb shows:

Thread 1 "firefox" received signal SIGSEGV, Segmentation fault.
0x00007fffe6a2b4ee in nsStyleChangeList::AppendChange(nsIFrame*, nsIContent*, nsChangeHint) () from /home/tomcat/quantum/firefox/libxul.so

Comment 1

[Hiroyuki Ikezoe (:hiro)]

This has been fixed somewhere between https://hg.mozilla.org/mozilla-central/rev/0260913ef653 and https://hg.mozilla.org/mozilla-central/rev/3d341b9ba535 .

Comment 2

[Hiroyuki Ikezoe (:hiro)]

FWIW, I don't track down which bug fixed the assertion in comment 0, but I could track down which bug fixed another assertion happened on the site in comment 0.  The assertion is:

Assertion failure: !mTrackingScripts.Contains(aURL), at /home/ikezoe/autoland/dom/base/nsDocument.cpp:3024

https://github.com/servo/servo/pull/14620 this servo PR fixed the assertion.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

How could that be the case? That PR doesn't even touch style code. We don't even compile that code in stylo.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #3)
> How could that be the case? That PR doesn't even touch style code. We don't
> even compile that code in stylo.

I am not sure.  I did just hg bisect.  So I maybe missed the real fix somewhere in the bisect.

Comment 5

[Carsten Book [:Tomcat]]

Assertion failure: aFrame || (aHint & nsChangeHint_ReconstructFrame) (must have frame), at /home/worker/workspace/build/src/layout/base/nsStyleChangeList.cpp just crashed with latest tinderbox stylo build based on Built from https://hg.mozilla.org/mozilla-central/rev/19289cc8bf6ffce3b2067fbe91aebea5a356d008 on http://hola.org/

Comment 6

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Reopening as per comment 5.

Comment 8

[Chris Peterson [:cpeterson]]

Hiro, are you still able to reproduce this assertion failure?

http://www.androidauthority.com/best-bluetooth-gaming-controllers-403184/

http://hola.org/

Comment 9

[Hiroyuki Ikezoe (:hiro)]

No!  Thanks!