Closed Bug 1339356 Opened 4 years ago Closed 3 years ago

stylo: Assertion failure: aFrame || (aHint & nsChangeHint_ReconstructFrame) (must have frame), at nsStyleChangeList.cpp:20

Categories

(Core :: Layout, defect, P2)

defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- disabled
firefox55 --- fixed

People

(Reporter: cbook, Unassigned)

References

()

Details

(Keywords: assertion)

Attachments

(1 file)

Assertion failure: aFrame || (aHint & nsChangeHint_ReconstructFrame) (must have frame), at /home/worker/workspace/build/src/layout/base/nsStyleChangeList.cpp:20

found via bughunter and reproduced on latest stylo debug build

Steps to reproduce:
-> Load http://www.androidauthority.com/best-bluetooth-gaming-controllers-403184/
--> Assertion failure 

gdb shows:

Thread 1 "firefox" received signal SIGSEGV, Segmentation fault.
0x00007fffe6a2b4ee in nsStyleChangeList::AppendChange(nsIFrame*, nsIContent*, nsChangeHint) () from /home/tomcat/quantum/firefox/libxul.so
FWIW, I don't track down which bug fixed the assertion in comment 0, but I could track down which bug fixed another assertion happened on the site in comment 0.  The assertion is:

Assertion failure: !mTrackingScripts.Contains(aURL), at /home/ikezoe/autoland/dom/base/nsDocument.cpp:3024

https://github.com/servo/servo/pull/14620 this servo PR fixed the assertion.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
How could that be the case? That PR doesn't even touch style code. We don't even compile that code in stylo.
(In reply to Emilio Cobos Álvarez [:emilio] from comment #3)
> How could that be the case? That PR doesn't even touch style code. We don't
> even compile that code in stylo.

I am not sure.  I did just hg bisect.  So I maybe missed the real fix somewhere in the bisect.
Assertion failure: aFrame || (aHint & nsChangeHint_ReconstructFrame) (must have frame), at /home/worker/workspace/build/src/layout/base/nsStyleChangeList.cpp just crashed with latest tinderbox stylo build based on Built from https://hg.mozilla.org/mozilla-central/rev/19289cc8bf6ffce3b2067fbe91aebea5a356d008 on http://hola.org/
Attached file bughunter stack
Reopening as per comment 5.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Priority: -- → P2
No longer blocks: stylo-nightly
Hiro, are you still able to reproduce this assertion failure?

http://www.androidauthority.com/best-bluetooth-gaming-controllers-403184/

http://hola.org/
Flags: needinfo?(hikezoe)
Summary: Assertion failure: aFrame || (aHint & nsChangeHint_ReconstructFrame) (must have frame), at nsStyleChangeList.cpp:20 → stylo: Assertion failure: aFrame || (aHint & nsChangeHint_ReconstructFrame) (must have frame), at nsStyleChangeList.cpp:20
No!  Thanks!
Status: REOPENED → RESOLVED
Closed: 4 years ago3 years ago
Flags: needinfo?(hikezoe)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.