Open Bug 1339434 Opened 9 years ago Updated 3 months ago

match spec change to remove skip-service-worker flag

Categories

(Core :: DOM: Service Workers, defect, P3)

Product:
Core
Component:
DOM: Service Workers
Type:
defect

Tracking

()

People

(Reporter: bkelly, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: dom-lws-bugdash-triage )

In this issue: https://github.com/whatwg/fetch/issues/303 The spec was changed not to blanket skip the service worker when network is initiated from a service worker. This removes the skip-service-worker flag and replaces it with another mode value. We should update to match the spec in order to properly intercept service-worker network requests like notification images, etc.
Priority: -- → P2
Priority: P2 → P3
Severity: normal → S3

So currently the notification image is downloaded rather directly via imgLoader::NormalLoader: https://searchfox.org/mozilla-central/rev/99f02d7a9456d4cfe2abd9c2a4a1eb8f3f41e22a/toolkit/components/alerts/AlertNotification.cpp#395-433

Some questions:

  • Do we want to change that to go through service worker? - I think Andrew basically said yes
  • Implementation interests for that?
  • Do we want to let Declarative Web Push run service worker that way?
Flags: needinfo?(bugmail)
Whiteboard: dom-lws-bugdash-triage
You need to log in before you can comment on or make changes to this bug.