1339458 - Ensure tests run with RUST_BACKTRACE=1 in the environment

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Now that we're getting more rust code in Firefox and running in automated tests, we should try to ensure that RUST_BACKTRACE=1 is set in all of our testing environments, because this can help debug crashes from rust panics. It certainly doesn't hurt to have the backtrace, and is more useful than a message saying "set RUST_BACKTRACE=1 to get a backtrace" :)

Comment 1

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Attachment: Bug 1339458 - Set RUST_BACKTRACE=1 when running automated tests.

Review commit: https://reviewboard.mozilla.org/r/112390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112390/

Comment 2

[Joel Maher ( :jmaher ) (UTC-4) (on leave, back October 1st)]

Comment on attachment 8837172 [details]
Bug 1339458 - Set RUST_BACKTRACE=1 when running automated tests.

https://reviewboard.mozilla.org/r/112390/#review113760

this is a nice simple patch, happy to re-review if you determine talos and android could use the same changes.

::: testing/mozharness/scripts/desktop_unittest.py:700
(Diff revision 1)
>                      env['MINIDUMP_STACKWALK'] = self.minidump_stackwalk_path
>                  if self.query_nodejs():
>                      env['MOZ_NODE_PATH'] = self.nodejs_path
>                  env['MOZ_UPLOAD_DIR'] = self.query_abs_dirs()['abs_blob_upload_dir']
>                  env['MINIDUMP_SAVE_PATH'] = self.query_abs_dirs()['abs_blob_upload_dir']
> +                env['RUST_BACKTRACE'] = '1'

do we need to do this for android as well?  What about talos?

Comment 3

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

(In reply to Joel Maher ( :jmaher) from comment #2)
> 
> do we need to do this for android as well?  What about talos?

Yeah we should probably do it for those as well. Where should I put it for those? I did some more grepping and found additional spots to add this in android_emulator_unittest.py, marionette.py, and web_platform_tests.py. Any other places I'm missing?

Comment 4

[Joel Maher ( :jmaher ) (UTC-4) (on leave, back October 1st)]

In addition to what you found, I believe we also need:
firefox_media_tests_taskcluster.py
firefox_ui_tests/functional.py
talos_script.py

Comment 5

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Comment on attachment 8837172 [details]
Bug 1339458 - Set RUST_BACKTRACE=1 when running automated tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112390/diff/1-2/

Comment 6

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Updated review request to catch them all! (cue pokemon music)

Comment 7

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Comment on attachment 8837172 [details]
Bug 1339458 - Set RUST_BACKTRACE=1 when running automated tests.

I don't know how to trigger a re-review from MozReview so I'm just setting the flag in bugzilla. :/

Comment 8

[Joel Maher ( :jmaher ) (UTC-4) (on leave, back October 1st)]

Comment on attachment 8837172 [details]
Bug 1339458 - Set RUST_BACKTRACE=1 when running automated tests.

https://reviewboard.mozilla.org/r/112390/#review113786

r+ again!

Comment 9

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Thanks :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d74575ffa14
Set RUST_BACKTRACE=1 when running automated tests. r=jmaher

Comment 11

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/5d74575ffa14