133948 - [PATCH]third nested table with height=100% rendered as height=auto until browser window is resized

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P2)

Description

[Ralf Vitasek]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
Gecko/20020314
BuildID:    2002031403

if you nest 3 (or more) tables with height=100% only the 2 outter tables are
rendered with correct height.

beginning with the third nested they're rendered like height=auto, but as soon
as you resize the browser window they'll fit.

btw: i saw tables dynamically grow on resizing a window, but the won't shrink
again until reload?!?

Reproducible: Always
Steps to Reproduce:
1. load http://www.neonblau.de/table.html
2. see the height of the  inner (red) table
3. resize the browser window

Actual Results:  inner tables height is incorrect until browser windows resize

Expected Results:  render the same on load

Comment 1

[karnaze (gone)]

*** This bug has been marked as a duplicate of 131020 ***

Comment 2

[Bernd]

thats not a dupe, it hasn't been fixed by the fix in bug 131020

Comment 3

[Ralf Vitasek]

bug description, first part is already resolved.

still to fix:

Reproducible: Always
Steps to Reproduce:
1. load http://www.neonblau.de/table.html (not in a maximized window!!!)
2. make the browser window smaller
3. push reload

Actual Results:  100% height tables grow dynamically, but will never shrink 
until page is reloaded

Expected Results:  render the same way as a single 100% height table (or the 
same way 100% width is rendered)

Comment 4

[karnaze (gone)]

Attachment: patch to fix the bug

Comment 5

[Kevin McCluskey (gone)]

nsbeta1+

Comment 6

[Marc Attinasi]

Comment on attachment 77366 [details] [diff] [review]
patch to fix the bug

sr=attinasi

Comment 7

[Bernd]

Comment on attachment 77366 [details] [diff] [review]
patch to fix the bug

r=bernd

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 77366 [details] [diff] [review]
patch to fix the bug

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin to 1.0.

Comment 10

[karnaze (gone)]

The patch is in.

Comment 11

[Ralf Vitasek]

cannot confirm a "RESOLVED" in nighly build 2002040708 !?!?
no difference on win xp pro. here

Comment 12

[karnaze (gone)]

I'm not sure what happened with that patch. Anyway, I'll be attaching an 
additional patch to be applied.

Comment 13

[karnaze (gone)]

Attachment: additional patch to be applied

The 1st patch is checked in and this one needs to be applied as well.

Comment 14

[Bernd]

Chris, why do we need to remove the resize_reflow in the decision at
nsTableCellFrame.cpp?

Comment 15

[karnaze (gone)]

This bug will be fixed with the patch in bug 125543. I am expanding that patch 
to include fixing this bug since bug 125543 deals with similar issues and is a 
more important bug.

During a resize reflow which preceeds a special height reflow, the computed 
height should not be set so the cell can change height. During the special 
height reflow the computed height will be set to allow percent height elements 
inside the cell to size properly.

Comment 16

[karnaze (gone)]

Comment on attachment 78204 [details] [diff] [review]
additional patch to be applied

will be included in the patch in bug 125543.

Comment 17

[Ralf Vitasek]

nightly build 2002041103 looks very good to me (winxp pro), nice work!

Comment 18

[Amarendra Hanumanula]

 Looks good. The table resizes with the browser window. Marking verified. 

Comment 19

[Amarendra Hanumanula]

 Adding verified1.0.0 keyword