Closed Bug 1339669 Opened 3 years ago Closed 3 years ago

sHSTSPrimingCacheTimeout is missing a factor of 60.

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: code, Assigned: kmckinley)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3004.3 Safari/537.36

Steps to reproduce:

Looked at https://dxr.mozilla.org/mozilla-central/source/dom/security/nsMixedContentBlocker.cpp#64


Actual results:

Saw the following code:

// Default HSTS Priming failure timeout to 7 days, in seconds
uint32_t nsMixedContentBlocker::sHSTSPrimingCacheTimeout = (60 * 24 * 7);


Expected results:

Presumably, the calculation should be (60 * 60 * 24 * 7)

I'd send a patch, but my computer is still busy installing Mercurial.
Component: Untriaged → DOM: Security
Product: Firefox → Core
Thanks Lucas! Somehow that slipped through.
Assignee: nobody → kmckinley
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8837886 [details]
Bug 1339669 - Update security.mixed_content.hsts_priming_cache_timeout default

https://reviewboard.mozilla.org/r/112876/#review115448

ups.  yes, it's a good practice to add time units to the pref name...
Attachment #8837886 - Flags: review?(honzab.moz) → review+
Pushed by kmckinley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60012e404044
Update security.mixed_content.hsts_priming_cache_timeout default r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/60012e404044
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.