1339745 - Sort the profile results for autocomplete popup by last used time

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement, P3)

Description

[Sean Lee [:seanlee][:weilonge]]

After having the last used time in ProfileStorage, the profiles got from parent should contain the usage information and sorted by the last used time.

Comment 1

[Steve Chung [:steveck]]

Attachment: Bug 1339745 - Sort the profile results for autocomplete popup by last used time,

Review commit: https://reviewboard.mozilla.org/r/150796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150796/

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8879489 [details]
Bug 1339745 - Sort the profile results for autocomplete popup by last used time,

https://reviewboard.mozilla.org/r/150796/#review155584

::: browser/extensions/formautofill/FormAutofillContent.jsm:115
(Diff revision 1)
>      this._getAddresses({info, searchString}).then((addresses) => {
>        if (this.forceStop) {
>          return;
>        }
> +      // Sort addresses by timeLastUsed for showing the lastest used address at top.
> +      addresses.sort((a, b) => b.timeLastUsed - a.timeLastUsed);

Should we add the second factor if two addresses are added but not used? Maybe `timeCreated`?

::: browser/extensions/formautofill/test/mochitest/test_on_address_submission.html:32
(Diff revision 1)
> -// Autofill the address from dropdown menu.
> +let expectingPopup = null;
> +function expectPopup() {
> +  info("expecting a popup");
> +  return new Promise(resolve => {
> +    expectingPopup = resolve;
> +  });
> +}
> +function popupShownListener() {
> +  info("popup shown for test ");
> +  if (expectingPopup) {
> +    expectingPopup();
> +    expectingPopup = null;
> +  }
> +}

Can these be shared from common.js?

Comment 3

[Steve Chung [:steveck]]

Comment on attachment 8879489 [details]
Bug 1339745 - Sort the profile results for autocomplete popup by last used time,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150796/diff/1-2/

Comment 4

[Steve Chung [:steveck]]

Comment on attachment 8879489 [details]
Bug 1339745 - Sort the profile results for autocomplete popup by last used time,

https://reviewboard.mozilla.org/r/150796/#review155584

> Should we add the second factor if two addresses are added but not used? Maybe `timeCreated`?

Since UX didn't really care about the sorting for addresses with same last used time, maybe we can ignore it unless user complains.

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8879489 [details]
Bug 1339745 - Sort the profile results for autocomplete popup by last used time,

https://reviewboard.mozilla.org/r/150796/#review156672

::: browser/extensions/formautofill/test/mochitest/formautofill_common.js:112
(Diff revision 2)
> +function popupShownListener() {
> +  info("popup shown for test ");
> +  if (expectingPopup) {
> +    expectingPopup();
> +    expectingPopup = null;
> +  }
> +}

Although I know it's unrelated to your patch, could you futher facilitate this util function by adding something like: 

```js
function initPopupListener() {
  registerPopupShownListener(popupShownListener);
}
```

Thanks.

::: browser/extensions/formautofill/test/mochitest/test_on_address_submission.html:62
(Diff revision 2)
> +    await setInput("#" + key, TEST_ADDRESSES[1][key]);
> +  }
> +
> +  clickOnElement("input[type=submit]");
> +
> +  // The 2nd test address should be on the top since it's the latest one.

nit: "... since it's the last used one".

Comment 6

[Steve Chung [:steveck]]

Comment on attachment 8879489 [details]
Bug 1339745 - Sort the profile results for autocomplete popup by last used time,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150796/diff/2-3/

Comment 7

[Steve Chung [:steveck]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26c2121cc1ef
Sort the profile results for autocomplete popup by last used time, r=lchang

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/26c2121cc1ef