1339765 - Replace NS_STYLE_GRID_TRACK_BREADTH_* with enum classes

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Ravi Shankar [:waffles]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c8e634cfed5

Comment 2

[Ravi Shankar [:waffles]]

Attachment: Bug 1339765 - Replace NS_STYLE_GRID_TRACK_BREADTH_* with enum classes;

Review commit: https://reviewboard.mozilla.org/r/113146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113146/

Comment 3

[Ravi Shankar [:waffles]]

The patch is required for auto-glue'ing Servo's (grid) TrackSize struct

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8838175 [details]
Bug 1339765 - Replace NS_STYLE_GRID_TRACK_BREADTH_* with enum classes;

https://reviewboard.mozilla.org/r/113146/#review114772

r=me with MaxContent = 1.

::: layout/style/nsStyleConsts.h:683
(Diff revision 1)
>  // CSS Grid <track-breadth> keywords
>  // Should not overlap with NS_STYLE_GRID_TEMPLATE_SUBGRID
> -#define NS_STYLE_GRID_TRACK_BREADTH_MAX_CONTENT 1
> -#define NS_STYLE_GRID_TRACK_BREADTH_MIN_CONTENT 2
> +enum class StyleGridTrackBreadth : uint8_t {
> +  MaxContent,
> +  MinContent,
> +};

I think we need to continue to avoid using 0 for these values, per the comment about not overlapping with NS_STYLE_GRID_TEMPLATE_SUBGRID.

Comment 5

[Ravi Shankar [:waffles]]

Comment on attachment 8838175 [details]
Bug 1339765 - Replace NS_STYLE_GRID_TRACK_BREADTH_* with enum classes;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/113146/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2915a5e35cd
Replace NS_STYLE_GRID_TRACK_BREADTH_* with enum classes;r=heycam

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2915a5e35cd