bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Replace NS_STYLE_GRID_TRACK_BREADTH_* with enum classes

RESOLVED FIXED in Firefox 54

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: waffles, Assigned: waffles)

Tracking

(Blocks: 1 bug)

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
The patch is required for auto-glue'ing Servo's (grid) TrackSize struct

Comment 4

a year ago
mozreview-review
Comment on attachment 8838175 [details]
Bug 1339765 - Replace NS_STYLE_GRID_TRACK_BREADTH_* with enum classes;

https://reviewboard.mozilla.org/r/113146/#review114772

r=me with MaxContent = 1.

::: layout/style/nsStyleConsts.h:683
(Diff revision 1)
>  // CSS Grid <track-breadth> keywords
>  // Should not overlap with NS_STYLE_GRID_TEMPLATE_SUBGRID
> -#define NS_STYLE_GRID_TRACK_BREADTH_MAX_CONTENT 1
> -#define NS_STYLE_GRID_TRACK_BREADTH_MIN_CONTENT 2
> +enum class StyleGridTrackBreadth : uint8_t {
> +  MaxContent,
> +  MinContent,
> +};

I think we need to continue to avoid using 0 for these values, per the comment about not overlapping with NS_STYLE_GRID_TEMPLATE_SUBGRID.
Attachment #8838175 - Flags: review?(cam) → review+
Comment hidden (mozreview-request)

Comment 6

a year ago
Pushed by Ms2ger@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e2915a5e35cd
Replace NS_STYLE_GRID_TRACK_BREADTH_* with enum classes;r=heycam

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e2915a5e35cd
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.